Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BFN] Enable m_isCombinedMirrorV6Table for BFN #1206

Merged
merged 1 commit into from
Feb 28, 2020

Conversation

msosyak
Copy link
Contributor

@msosyak msosyak commented Feb 26, 2020

What I did
Enable m_isCombinedMirrorV6Table for BFN

Why I did it
Due to internal changes in the BFN platform

How I verified it

Details if related

Copy link
Collaborator

@prsunny prsunny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this require a corresponding SDK update?

@msosyak
Copy link
Contributor Author

msosyak commented Feb 28, 2020

@prsunny No changes in SDE required. Could we merge this?

@prsunny prsunny merged commit 0bf0acb into sonic-net:201911 Feb 28, 2020
prsunny added a commit that referenced this pull request Feb 28, 2020
@prsunny
Copy link
Collaborator

prsunny commented Feb 28, 2020

@msosyak , i reverted the merge as you would want to raise the PR to master and mark for cherry-pick to 201911. Why is it raised to 201911 directly?

@msosyak
Copy link
Contributor Author

msosyak commented Mar 2, 2020

@msosyak , i reverted the merge as you would want to raise the PR to master and mark for cherry-pick to 201911. Why is it raised to 201911 directly?

@prsunny 201911 is more urgent then master.
Here is the PR for mater #1212.

Should I open new PR to 201911 to have these changes? Or you could revert the #1209?

msosyak added a commit to msosyak/sonic-swss that referenced this pull request Mar 4, 2020
oleksandrivantsiv pushed a commit to oleksandrivantsiv/sonic-swss that referenced this pull request Mar 1, 2023
include changes:
0031470 |  improve enum values integration check (sonic-net#1727) (sonic-net#1737)

Signed-off-by: richardyu-ms <richard.yu@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants