Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #3971 by skipping create-only SAI attributes when modifying buffer pools or profiles in orchagent #1430

Merged
merged 2 commits into from
Sep 15, 2020

Conversation

stephenxs
Copy link
Collaborator

What I did
Skip create-only fields when modify buffer pool or profile in orchagent
This PR also fixes the issue dynamic_th failed because redis sends unchanged field to orchagent when updating dynamic_th #3971

Signed-off-by: Stephen Sun stephens@nvidia.com

Why I did it

How I verified it

Details if related

This PR also fixes the issue #3971 redis sends unchanged field

Signed-off-by: Stephen Sun <stephens@mellanox.com>
orchagent/bufferorch.cpp Outdated Show resolved Hide resolved
orchagent/bufferorch.cpp Outdated Show resolved Hide resolved
orchagent/bufferorch.cpp Outdated Show resolved Hide resolved
Signed-off-by: Stephen Sun <stephens@nvidia.com>
@stephenxs stephenxs requested a review from yxieca September 9, 2020 02:18
@yxieca
Copy link
Contributor

yxieca commented Sep 9, 2020

@prsunny can you also take a look?

@yxieca yxieca requested a review from prsunny September 9, 2020 16:54
@yxieca yxieca merged commit 7b15a65 into sonic-net:master Sep 15, 2020
@stephenxs stephenxs deleted the skip-create-only-attribute branch September 15, 2020 22:13
abdosi pushed a commit that referenced this pull request Sep 19, 2020
…r pools or profiles in orchagent (#1430)

* Skip create-only fields when modify buffer pool or profile in orchagent

This PR also fixes the issue #3971 redis sends unchanged field

Signed-off-by: Stephen Sun <stephens@mellanox.com>

* Fix review comments

Signed-off-by: Stephen Sun <stephens@nvidia.com>

Co-authored-by: Stephen Sun <stephens@mellanox.com>
EdenGri pushed a commit to EdenGri/sonic-swss that referenced this pull request Feb 28, 2022
…1430)

What I did
sort output by time
improve lag support according to event format changes
add an option to sort the log files by a field of file name (after log files got moved or copied, sorting by timestamp is no longer reliable).
Signed-off-by: Ying Xie ying.xie@microsoft.com

How to verify it
run 'sudo storyteller --since "2021-2-10" -c lag' on a dut
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants