Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tests] Remove legacy saiattributelist.h dependency #1608

Merged
merged 2 commits into from
Feb 8, 2021

Conversation

kcudnik
Copy link
Contributor

@kcudnik kcudnik commented Jan 25, 2021

Signed-off-by: kcudnik kcudnik@gmail.com

What I did
Remove legacysaiattributelist.h dependency

Why I did it
This file was refactored in sairedis repo to SaiAttributeList.h proper class

How I verified it
locally compile

Details if related
Copy contents of saiattributelis.h directly to check.h

Signed-off-by: kcudnik <kcudnik@gmail.com>
@kcudnik
Copy link
Contributor Author

kcudnik commented Jan 25, 2021

retest vs please

1 similar comment
@kcudnik
Copy link
Contributor Author

kcudnik commented Jan 25, 2021

retest vs please

@kcudnik
Copy link
Contributor Author

kcudnik commented Jan 27, 2021

retest vs please

1 similar comment
@kcudnik
Copy link
Contributor Author

kcudnik commented Jan 29, 2021

retest vs please

@kcudnik
Copy link
Contributor Author

kcudnik commented Feb 1, 2021

ping

@kcudnik kcudnik requested a review from lguohan February 1, 2021 16:42
@kcudnik
Copy link
Contributor Author

kcudnik commented Feb 8, 2021

ping

@kcudnik kcudnik merged commit 6554b5d into sonic-net:master Feb 8, 2021
@kcudnik kcudnik deleted the sailist branch February 8, 2021 17:50
daall pushed a commit that referenced this pull request Feb 17, 2021
This file was refactored in sairedis repo to SaiAttributeList.h proper class
DavidZagury pushed a commit to DavidZagury/sonic-swss that referenced this pull request Mar 4, 2021
This file was refactored in sairedis repo to SaiAttributeList.h proper class
raphaelt-nvidia pushed a commit to raphaelt-nvidia/sonic-swss that referenced this pull request Oct 5, 2021
This file was refactored in sairedis repo to SaiAttributeList.h proper class
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants