Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[System Port] Initialize system port 'type' variable #1681

Merged
merged 1 commit into from
Mar 26, 2021

Conversation

prsunny
Copy link
Collaborator

@prsunny prsunny commented Mar 25, 2021

What I did
Initialize System port type variable to SAI_SYSTEM_PORT_TYPE_LOCAL

Why I did it

Fix PR builds failed with kvm-t1-lag tests on route_check script.

How I verified it

Details if related

Logs:

  1. Route add failed for get nexthop:

Mar 25 06:17:38.194329 vlab-03 INFO swss#orchagent: :- addRoute: Failed to get next hop 10.0.0.33@Ethernet64 for 100.1.0.17/32

  1. During add Nexthop, the alias field got replaced due to incorrect return value returned as True

  2. Nexthop alias field became empty while adding to cache, which resulted in mismatch of route get

Mar 25 20:32:44.180521 vlab-03 NOTICE swss#orchagent: :- addNextHop: RCF: Existing Nexthops IP:10.0.0.33, Alias:, nhid:0x40000000006aa

@prsunny prsunny requested a review from lguohan March 25, 2021 22:03
@prsunny
Copy link
Collaborator Author

prsunny commented Mar 25, 2021

@vganesan-nokia , @minionatwork for viz

@prsunny prsunny merged commit 5adb73e into sonic-net:master Mar 26, 2021
@prsunny prsunny deleted the kvmtest branch March 26, 2021 00:51
@stephenxs
Copy link
Collaborator

Hi @prsunny
Do we need this PR for 202012?

@prsunny
Copy link
Collaborator Author

prsunny commented Apr 2, 2021

Hi @prsunny
Do we need this PR for 202012?

No, the change is introduced as part of this PR - #1431 and not present in 202012

@stephenxs
Copy link
Collaborator

Hi @prsunny
Do we need this PR for 202012?

No, the change is introduced as part of this PR - #1431 and not present in 202012

Got it. Thank you.

raphaelt-nvidia pushed a commit to raphaelt-nvidia/sonic-swss that referenced this pull request Oct 5, 2021
Initialize System port type variable to SAI_SYSTEM_PORT_TYPE_LOCAL
EdenGri pushed a commit to EdenGri/sonic-swss that referenced this pull request Feb 28, 2022
…t#1681)

Make the soft-reboot available in the SONiC image on master

What I did
Add soft-reboot to build package

How I did it
Add "soft-reboot" to the package list of sonic-utility/setup.py

How to verify it
Build a SONiC image, load the image to DUT and check if soft-reboot is available.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants