set remote vtep the netdev down before delete. #2075
Conversation
|
@srj102 , @dgsudharsan for review |
cfgmgr/vxlanmgr.cpp
Outdated
| @@ -78,6 +78,16 @@ static int cmdUpVxlan(const swss::VxlanMgr::VxlanInfo & info, std::string & res) | |||
| return swss::exec(cmd.str(), res); | |||
| } | |||
|
|
|||
| static int cmdDownVxlan(const swss::VxlanMgr::VxlanInfo & info, std::string & res) | |||
There was a problem hiding this comment.
This comes in VNET flow and not in regular EVPN flow. Is it needed?
cfgmgr/vxlanmgr.cpp
Outdated
| @@ -130,6 +140,16 @@ static int cmdUpVxlanIf(const swss::VxlanMgr::VxlanInfo & info, std::string & re | |||
| return swss::exec(cmd.str(), res); | |||
| } | |||
|
|
|||
| static int cmdDownVxlanIf(const swss::VxlanMgr::VxlanInfo & info, std::string & res) | |||
There was a problem hiding this comment.
Same as above. These APIs are called only for VNET table. Are these changes needed?
Agree with @dgsudharsan , this doesn't fall into the EVPN flow. Can you please check what's intended? |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
@iris00522 Can you please sync your changes to latest master? |
|
@dgsudharsan @prsunny help to review again, thank you. |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Commenter does not have sufficient privileges for PR 2075 in repo Azure/sonic-swss |
|
@dgsudharsan @prsunny can this PR be merged? Thanks |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
@dgsudharsan , can you please signoff? |
*set vtep-xxx the netdev down before delete vtep-xxx .
*set vtep-xxx the netdev down before delete vtep-xxx .
What I did
set vtep-xxx the netdev down before delete vtep-xxx .
Why I did it
the vxlan netdev will be only delete only when remove vxlan tunnel map,
but the FRR doesn't remove IMET route entirely after receiving the delete event.
Therefore, add to set netdev down before delete the netdev to trigger FRR to remove related IMET route.
How I verified it
using t0 topology config
and flow the cmmand
redis-cli -n 4 -c DEL "VLAN_MEMBER|Vlan1000|Ethernet4"
sudo config interface ip add Ethernet4 10.0.0.64/31
vtysh
configure
ip route 100.0.0.65/31 10.0.0.65
exit
exit
sudo config vxlan add vtep 10.1.0.32
sudo config vxlan evpn_nvo add evpnnvo1 vtep
sudo config vxlan map add vtep 1000 10000
vtysh
configure
router bgp 65100
neighbor 10.0.0.65 remote-as 65200
address-family l2vpn evpn
neighbor 10.0.0.65 activate
advertise-all-vni
exit
exit
exit
exit
neighbor:
setting bgp and type 3 and typ2 packet
Details if related