Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[subinterface] Fix admin state handling #2806

Merged
merged 1 commit into from
Jun 14, 2023

Conversation

nazariig
Copy link
Collaborator

@nazariig nazariig commented May 31, 2023

closes sonic-net/sonic-buildimage#15282

The bug is caused by a logic in intfmgr which aims to reduce the redundant admin state configuration.
Because of that, intfsorch falls back to defaults and treats admin state configuration as disabled.

These changes allow to reset port admin state to it's default value,
when configuration is not received by producer-consumer mechanism.

What I did

  • Fixed invalid RIF admin state during VNET port subinterface configuration

Why I did it

  • To resolve the issue with RIF admin state configuration

How I verified it

  • Run VS tests

Details if related

  • N/A

@nazariig nazariig requested a review from volodymyrsamotiy May 31, 2023 15:42
@nazariig nazariig force-pushed the master-subintf-admin-state branch from 372ecb9 to 06afb21 Compare May 31, 2023 16:07
@nazariig nazariig marked this pull request as ready for review May 31, 2023 20:22
@nazariig nazariig requested a review from prsunny as a code owner May 31, 2023 20:23
@nazariig nazariig requested review from prgeor and qiluo-msft May 31, 2023 23:14
Signed-off-by: Nazarii Hnydyn <nazariig@nvidia.com>
@nazariig nazariig force-pushed the master-subintf-admin-state branch from 06afb21 to bef9323 Compare June 1, 2023 07:49
@nazariig nazariig changed the title [subintf] Fix admin state handling [subinterface] Fix admin state handling Jun 1, 2023
@nazariig
Copy link
Collaborator Author

nazariig commented Jun 1, 2023

@prsunny / @qiluo-msft would you please have a look? This is a blocker for Port Profile Init feature

@nazariig
Copy link
Collaborator Author

nazariig commented Jun 7, 2023

@prsunny / @qiluo-msft just a kind reminder

@prsunny
Copy link
Collaborator

prsunny commented Jun 12, 2023

Can you please fix the description to have proper details on fix? I need this for creating the commit message

@nazariig
Copy link
Collaborator Author

Can you please fix the description to have proper details on fix? I need this for creating the commit message

@prsunny done

@nazariig
Copy link
Collaborator Author

@prsunny would you please help to merge?

@prsunny prsunny merged commit c7e52a0 into sonic-net:master Jun 14, 2023
yxieca pushed a commit that referenced this pull request Jun 15, 2023
Fix the bug caused by a logic in intfmgr which aims to reduce the redundant admin state configuration.
Because of that, intfsorch falls back to defaults and treats admin state configuration as disabled.

These changes allow to reset port admin state to it's default value, when configuration is not received by producer-consumer mechanism.
@nazariig
Copy link
Collaborator Author

@yxieca would you please cherry-pick to 202211?

yxieca pushed a commit that referenced this pull request Jun 29, 2023
Fix the bug caused by a logic in intfmgr which aims to reduce the redundant admin state configuration.
Because of that, intfsorch falls back to defaults and treats admin state configuration as disabled.

These changes allow to reset port admin state to it's default value, when configuration is not received by producer-consumer mechanism.
theasianpianist pushed a commit to theasianpianist/sonic-swss that referenced this pull request Jul 20, 2023
Fix the bug caused by a logic in intfmgr which aims to reduce the redundant admin state configuration.
Because of that, intfsorch falls back to defaults and treats admin state configuration as disabled.

These changes allow to reset port admin state to it's default value, when configuration is not received by producer-consumer mechanism.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[subinterface] Invalid RIF admin state is set during vnet port subinterface configuration
4 participants