[intfmgr]: Support configuring IPs for all regular interfaces #544
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stcheng
changed the title
jipanyang
reviewed
Jul 24, 2018
|
@jipanyang This commit is to address the intfmgrd so that it supports the configurations via the database. I'll then remove the |
|
@stcheng Thanks for the explanation, change looks good to me. |
|
do not merge until to have the buildimage pr ready to merge. |
jleveque
suggested changes
Jul 31, 2018
cfgmgr/intfmgr.cpp
Outdated
| } | ||
| else | ||
| { | ||
| cmd <<IP_CMD << " -6 address " << opCmd << " " << ipPrefixStr << " dev " << alias;; |
There was a problem hiding this comment.
- Add space between
<<andIP_CMD - Remove extra trailing semicolon.
cfgmgr/intfmgr.cpp
Outdated
| cmd << IP_CMD << " address " << opCmd << " " << ipPrefixStr << " dev " << alias;; | ||
| if (ipv4) | ||
| { | ||
| cmd << IP_CMD << " address " << opCmd << " " << ipPrefixStr << " dev " << alias;; |
There was a problem hiding this comment.
Remove extra trailing semicolon.
Enable configuring IPv4 and IPv6 addresses on regular ports Add tests to test IPv4 add/remove to regular ports Signed-off-by: Shu0T1an ChenG <shuche@microsoft.com>
jleveque
approved these changes
Aug 9, 2018
oleksandrivantsiv
pushed a commit
to oleksandrivantsiv/sonic-swss
that referenced
this pull request
Mar 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enable configuring IPv4 and IPv6 addresses on regular ports
Add tests to test IPv4 add/remove to regular ports
Signed-off-by: Shu0T1an ChenG shuche@microsoft.com
NOTE: