[portsorch]: Support LAG MTU configuration #581
Conversation
- LAG MTU configuration is now on stage - By default, the MTU of port channel based router interface is 9100. - If a new MTU is applied to the port channel via configuration database, this new MTU will be used 1) to the netdev in the kernel via ip command; 2) to all the member netdevs in the kernel via teamd; 3) to the port channel based router interface MTU; 4) to all the member port MTU. - Remove the libnl MTU from teamsyncd - Refactor test_interface.py tests. Each one test is independent from the other test. The switch will be cleaned up at the end of the test. Signed-off-by: Shu0T1an ChenG <shuche@microsoft.com>
|
note: port channel member manipulation is not part of this pull request. MTU changes associated with membership changes will be in the future pull requests. |
|
can you fix the test failure? |
|
the test failure is due to the old docker-vs |
| vector<FieldValueTuple> member_fvs; | ||
| FieldValueTuple member_fv("mtu", mtu); | ||
| member_fvs.push_back(member_fv); | ||
| m_appPortTable.set(member, member_fvs); |
There was a problem hiding this comment.
If the port mtu is overwritten by the lag mtu value, what happens when the port is removed from lag later? Is it handled?
There was a problem hiding this comment.
my earlier notes in this pull request says that this won't cover the MTU changes associated with the port channel membership changes. i'll go and cover those cases when i add the support for configuring port channel memberships
There was a problem hiding this comment.
this pull request will focus only on the MTU configurations with out changing the members of the port channels
There was a problem hiding this comment.
Oh ok, didn't notice the notes.
| dvs.runcmd("teamd -k -t" + interface) | ||
| time.sleep(1) | ||
|
|
||
| def add_port_channel_members(self, dvs, interface, members): |
There was a problem hiding this comment.
Can we also have a test case to remove_port_channel_members?
There was a problem hiding this comment.
will add this along with port channel membership configuration changes
* [meta] Flush fdb entries after flush api success * [meta] Use correct fdb entry type * [meta] Use correct enum values for fdb entry
LAG MTU configuration is now on stage
By default, the MTU of port channel based router interface is 9100.
If a new MTU is applied to the port channel via configuration
database, this new MTU will be used 1) to the netdev in the kernel
via ip command; 2) to all the member netdevs in the kernel via teamd;
3) to the port channel based router interface MTU; 4) to all the
member port MTU.
Remove the libnl MTU from teamsyncd
Refactor test_interface.py tests. Each one test is independent from
the other test. The switch will be cleaned up at the end of the test.
Signed-off-by: Shu0T1an ChenG shuche@microsoft.com