-
Notifications
You must be signed in to change notification settings - Fork 547
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support ConfigDB neighbor configuration, introduce nbrmgr daemon #693
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it possible to use libnl3 for netlink programming?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
as comments
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the case of mac address of the neighbor is empty, how would neighmgr handle warm restart/warm reboot scenarios? Some cooperation with neighsyncd seems necessary.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approve from my side. Please check Jipans' comments
@jipanyang, as mentioned in description, plan is to merge neighsyncd and neighbor manager in next phase. I'll consider the warm-restart scenarios along with that. For the current use-case, we can skip the warm-restart requirements. |
* Per-switching silicon Common config for Broadcom Supported Platforms.
What I did
Initial commit to support ConfigDB neighbor table configurations
Why I did it
Requirement to resolve mac address for a configured neighbor IP. Also support static neighbor configuration
How I verified it
Logs:
Resolve case:
Static Nbr:
Details if related
This is the initial commit for phase 1.
For phase 2: