Adding QOS schema changes #7

hrachya-m · 2016-03-23T15:46:28Z

Contains

definitions of QOS related ABNF tokens
samples
definition for JSON configuration file.

eladraz · 2016-03-23T19:25:24Z

doc/swss-schema.md

 ###PORT_TABLE
-Stores information for physical switch ports managed by the switch chip.  device_names are defined in [port_config.ini](../portsyncd/port_config.ini).  Ports to the CPU (ie: management port) and logical ports (loopback) are not declared in the PORT_TABLE.   See INTF_TABLE.
+Stores information for physical switch ports managed by the switch chip.  device_names are defined in [port_config.ini](https://github.com/stcheng/swss/blob/mock/portsyncd/port_config.ini).  Ports to the CPU (ie: management port) and logical ports (loopback) are not declared in the PORT_TABLE.   See INTF_TABLE.



Please rebase to latest

eladraz · 2016-03-23T19:29:44Z

Please format the commit message as in README.md (Signed-off-by and commit tittle)

eladraz · 2016-03-23T19:31:51Z

doc/swss-schema.md

+	; "queue_index"					  1
+	; key QUEUE_TABLE:RDMA
+	;		field_name				value
+	; "queue_index"					  4


I just want to understand. This table translate queue indexes to names? (e.g. BEST_EFFORT/RDMA/etc?)
If so, why it's needed?

QUEUE_TABLE is similar to the PORT_TABLE. Each entry in the the queue_table should represent a queue instance on a specific port in the system. Then, it also has a set of attributes that is associated with the queue.

Contains - definitions of QOS related ABNF tokens - samples - definition for JSON configuration file.

1. Definitions of QOS related ABNF tokens, merge QOS data into ports and define QUEUE_TABLE. 2. Samples Signed-off-by: Hrachya Mughnetsyan <hrachya@mellanox.com>

lguohan · 2016-04-01T15:58:12Z

Ack

stcheng · 2016-04-04T21:53:42Z

merged

break one line into multiple lines

* Add API to access config db

* Add SONiC CLI as a Python package * Debian package is now built using Python setuptools instead of dpkg-buildpackage * Create sonic_eeprom and sonic_sfp Python packages to cleanly house modules * Merge changes from internal repo

**What I did** Fix the Mem Leak by moving the raw pointers in type_maps to use smart pointers **Why I did it** ``` Indirect leak of 83776 byte(s) in 476 object(s) allocated from: #0 0x7f0a2a414647 in operator new(unsigned long) ../../../../src/libsanitizer/asan/asan_new_delete.cpp:99 #1 0x5555590cc923 in __gnu_cxx::new_allocator, std::allocator > const, referenced_object> > >::allocate(unsigned long, void const*) /usr/include/c++/10/ext/new_allocator.h:115 #2 0x5555590cc923 in std::allocator_traits, std::allocator > const, referenced_object> > > >::allocate(std::allocator, std::allocator > const, referenced_object> > >&, unsigned long) /usr/include/c++/10/bits/alloc_traits.h:460 #3 0x5555590cc923 in std::_Rb_tree, std::allocator >, std::pair, std::allocator > const, referenced_object>, std::_Select1st, std::allocator > const, referenced_object> >, std::less, std::allocator > >, std::allocator, std::allocator > const, referenced_object> > >::_M_get_node() /usr/include/c++/10/bits/stl_tree.h:584 #4 0x5555590cc923 in std::_Rb_tree_node, std::allocator > const, referenced_object> >* std::_Rb_tree, std::allocator >, std::pair, std::allocator > const, referenced_object>, std::_Select1st, std::allocator > const, referenced_object> >, std::less, std::allocator > >, std::allocator, std::allocator > const, referenced_object> > >::_M_create_node, std::allocator > const&>, std::tuple<> >(std::piecewise_construct_t const&, std::tuple, std::allocator > const&>&&, std::tuple<>&&) /usr/include/c++/10/bits/stl_tree.h:634 #5 0x5555590cc923 in std::_Rb_tree_iterator, std::allocator > const, referenced_object> > std::_Rb_tree, std::allocator >, std::pair, std::allocator > const, referenced_object>, std::_Select1st, std::allocator > const, referenced_object> >, std::less, std::allocator > >, std::allocator, std::allocator > const, referenced_object> > >::_M_emplace_hint_unique, std::allocator > const&>, std::tuple<> >(std::_Rb_tree_const_iterator, std::allocator > const, referenced_object> >, std::piecewise_construct_t const&, std::tuple, std::allocator > const&>&&, std::tuple<>&&) /usr/include/c++/10/bits/stl_tree.h:2461 #6 0x5555590e8757 in std::map, std::allocator >, referenced_object, std::less, std::allocator > >, std::allocator, std::allocator > const, referenced_object> > >::operator[](std::__cxx11::basic_string, std::allocator > const&) /usr/include/c++/10/bits/stl_map.h:501 #7 0x5555590d48b0 in Orch::setObjectReference(std::map, std::allocator >, std::map, std::allocator >, referenced_object, std::less, std::allocator > >, std::allocator, std::allocator > const, referenced_object> > >*, std::less, std::allocator > >, std::allocator, std::allocator > const, std::map, std::allocator >, referenced_object, std::less, std::allocator > >, std::allocator, std::allocator > const, referenced_object> > >*> > >&, std::__cxx11::basic_string, std::allocator > const&, std::__cxx11::basic_string, std::allocator > const&, std::__cxx11::basic_string, std::allocator > const&, std::__cxx11::basic_string, std::allocator > const&) orchagent/orch.cpp:450 #8 0x5555594ff66b in QosOrch::handleQueueTable(Consumer&, std::tuple, std::allocator >, std::__cxx11::basic_string, std::allocator >, std::vector, std::allocator >, std::__cxx11::basic_string, std::allocator > >, std::allocator, std::allocator >, std::__cxx11::basic_string, std::allocator > > > > >&) orchagent/qosorch.cpp:1763 #9 0x5555594edbd6 in QosOrch::doTask(Consumer&) orchagent/qosorch.cpp:2179 #10 0x5555590c8743 in Consumer::drain() orchagent/orch.cpp:241 #11 0x5555590c8743 in Consumer::drain() orchagent/orch.cpp:238 #12 0x5555590c8743 in Consumer::execute() orchagent/orch.cpp:235 #13 0x555559090dad in OrchDaemon::start() orchagent/orchdaemon.cpp:755 #14 0x555558e9be25 in main orchagent/main.cpp:766 #15 0x7f0a299b6d09 in __libc_start_main (/lib/x86_64-linux-gnu/libc.so.6+0x23d09) ```

eladraz reviewed Mar 23, 2016
View reviewed changes

lguohan and others added 2 commits March 28, 2016 20:48

update build procedure

f8e245c

Adding QOS schema changes

4b6b93d

Contains - definitions of QOS related ABNF tokens - samples - definition for JSON configuration file.

hrachya-m force-pushed the qosschema branch from 30639dc to bc12f25 Compare March 29, 2016 00:00

QOS schema modifications

2650588

1. Definitions of QOS related ABNF tokens, merge QOS data into ports and define QUEUE_TABLE. 2. Samples Signed-off-by: Hrachya Mughnetsyan <hrachya@mellanox.com>

hrachya-m force-pushed the qosschema branch from bc12f25 to 2650588 Compare March 29, 2016 00:03

lguohan closed this Apr 1, 2016

lguohan reopened this Apr 1, 2016

stcheng force-pushed the master branch from d2864a6 to 2b6997c Compare April 4, 2016 21:47

stcheng closed this Apr 4, 2016

jipanyang mentioned this pull request Oct 13, 2017

orchagent hangs at switchorch due to erase operation on map #347

Closed

vharish02 pushed a commit to vharish02/sonic-swss that referenced this pull request Aug 6, 2018

Formated (sonic-net#7)

af1882a

break one line into multiple lines

ishidawataru pushed a commit to ishidawataru/sonic-swss that referenced this pull request Aug 29, 2018

Add API to access config db (sonic-net#7)

dfe4bac

* Add API to access config db

judyjoseph mentioned this pull request Dec 13, 2019

teamsyncd::Additional checks put inplace to make sure the netlink message is valid #1144

Closed

garigipati mentioned this pull request May 22, 2020

Applying the same Vnet's twice causes orchagent crash #1298

Closed

dgsudharsan referenced this pull request in dgsudharsan/sonic-swss Jun 22, 2021

Changes #7 Fixes

594b136

skbarista mentioned this pull request Nov 29, 2022

sonic-swss: Fix orchagent crash in generateQueueMapPerPort. #2552

Merged

oleksandrivantsiv referenced this pull request in oleksandrivantsiv/sonic-swss Mar 1, 2023

Add more ignore patterns (#7)

5f1df4d

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Adding QOS schema changes #7

Adding QOS schema changes #7

hrachya-m commented Mar 23, 2016

eladraz Mar 23, 2016

eladraz commented Mar 23, 2016

eladraz Mar 23, 2016

lguohan Mar 25, 2016

lguohan commented Apr 1, 2016

stcheng commented Apr 4, 2016

Adding QOS schema changes #7

Adding QOS schema changes #7

Conversation

hrachya-m commented Mar 23, 2016

eladraz Mar 23, 2016

Choose a reason for hiding this comment

eladraz commented Mar 23, 2016

eladraz Mar 23, 2016

Choose a reason for hiding this comment

lguohan Mar 25, 2016

Choose a reason for hiding this comment

lguohan commented Apr 1, 2016

stcheng commented Apr 4, 2016