[portsorch] Don't flap port when setting speed if port is down #764
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prsunny
reviewed
Jan 23, 2019
|
retest this please |
1 similar comment
|
retest this please |
stepanblyschak
force-pushed
the
speed_set
branch
2 times, most recently
from
3a671da
to
1875a53
Compare
stepanblyschak
force-pushed
the
speed_set
branch
3 times, most recently
from
8c1b5bc
to
b8836b3
Compare
- Cache port admin status and speed in port structure in initializePort(); - Don't flap port if port is already down during speed set; - Don't set admin status if desired status is already set; - Set admin status as last step in doPortTask() Signed-off-by: Stepan Blyschak <stepanb@mellanox.com>
stepanblyschak
force-pushed
the
speed_set
branch
from
b8836b3
to
baee1e2
Compare
|
retest this please |
prsunny
approved these changes
Feb 20, 2019
|
Made to 201811 branch on 2/21/2019 |
yxieca
pushed a commit
that referenced
this pull request
Feb 21, 2019
- Cache port admin status and speed in port structure in initializePort(); - Don't flap port if port is already down during speed set; - Don't set admin status if desired status is already set; - Set admin status as last step in doPortTask() Signed-off-by: Stepan Blyschak <stepanb@mellanox.com>
EdenGri
pushed a commit
to EdenGri/sonic-swss
that referenced
this pull request
Feb 28, 2022
Signed-off-by:yangshiping@jd.com
oleksandrivantsiv
pushed a commit
to oleksandrivantsiv/sonic-swss
that referenced
this pull request
Mar 1, 2023
…riority (sonic-net#764) * [syncd] Add best candidate finder based on attr label * [meta] Support chardata attr value on set validation * [tests] Add unittests for lag label attribute comparison logic * [tests] Add no lag label to lag label unittests * [tests] Export color function
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
When port is already down during speed configuration don't put port down again.
Cache admin status in Port structure, do not set admin port status again if already set.
Why I did it
Avoid unnessesary SAI calls. It also had implications on Mellanox fastfast boot solution causing port flapping.
How I verified it
Currently VS fails (Check sonic-net/sonic-sairedis#419)
Verified it is passing all VS tests.
Mannual testing.
Details if related