[vstest]: fix test_port_an_warm.py test #779
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the test should set the speed and autoneg in config db instead of application db. As if the speed in config db is not changed, it will override the value in app db after warm reboot Signed-off-by: Guohan Lu <gulv@microsoft.com>
|
@jipanyang to review |
jipanyang
approved these changes
Feb 1, 2019
There was a problem hiding this comment.
Passed my local test too. thanks.
jipan@jipan_sonic_vm_150:~/vs/sonic-buildimage/src/sonic-swss/tests$ sudo pytest -v --dvsname=vs test_port_an_warm.py
============================================================================== test session starts ==============================================================================
platform linux2 -- Python 2.7.15rc1, pytest-3.3.0, py-1.5.3, pluggy-0.6.0 -- /usr/bin/python
cachedir: .cache
rootdir: /home/jipan/vs/sonic-buildimage/src/sonic-swss/tests, inifile:
collected 1 item
test_port_an_warm.py::test_PortAutoNeg_warm PASSED [100%]
=========================================================================== 1 passed in 42.18 seconds ===========================================================================
jipan@jipan_sonic_vm_150:~/vs/sonic-buildimage/src/sonic-swss/tests$
|
test_speed.py fix in #780 |
|
Made to 201811 branch on 2/4/2019 |
yxieca
pushed a commit
that referenced
this pull request
Feb 5, 2019
the test should set the speed and autoneg in config db instead of application db. As if the speed in config db is not changed, it will override the value in app db after warm reboot Signed-off-by: Guohan Lu <gulv@microsoft.com>
oleksandrivantsiv
pushed a commit
to oleksandrivantsiv/sonic-swss
that referenced
this pull request
Mar 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the test should set the speed and autoneg in config db instead
of application db. As if the speed in config db is not changed,
it will override the value in app db after warm reboot
Signed-off-by: Guohan Lu gulv@microsoft.com
What I did
Why I did it
How I verified it
Details if related