[orchagent] Fix orchagent SEGV when PortConfigDone not set #803
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jleveque
approved these changes
Feb 26, 2019
|
Thanks for fixing this bug! Could you add a vs test? |
|
Sorry, I don’t have a VS test setup. Hoping to pick it up from workshop planned next month.
…-Ramesh
From: Qi Luo <notifications@github.com>
Reply-To: Azure/sonic-swss <reply@reply.github.com>
Date: Monday, February 25, 2019 at 6:51 PM
To: Azure/sonic-swss <sonic-swss@noreply.github.com>
Cc: "Ramesh Santhanakrishnan (rameshms)" <rameshms@cisco.com>, Author <author@noreply.github.com>
Subject: Re: [Azure/sonic-swss] [orchagent] Fix orchagent SEGV when PortConfigDone not set (#803)
@qiluo-msft requested changes on this pull request.
As comment
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub<#803 (review)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AVODMxNjX7eSzVvdvpFZlAeDDQqZw6aVks5vRKETgaJpZM4bRMZg>.
|
|
retest this please |
1 similar comment
|
retest this please |
stcheng
approved these changes
Feb 28, 2019
lguohan
dismissed
qiluo-msft’s stale review
the developer does not have the vs test setup right now.
yxieca
pushed a commit
that referenced
this pull request
Mar 19, 2019
oleksandrivantsiv
pushed a commit
to oleksandrivantsiv/sonic-swss
that referenced
this pull request
Mar 1, 2023
Allow SAI xml dynamic config override when template is defined Signed-off-by: Nazarii Hnydyn <nazariig@nvidia.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Fix uninitialized value access
Why I did it
To fix following error:
Feb 25 22:34:17.837004 switch120 NOTICE swss#orchagent: :- bake: Add warm input: BUFFER_PROFILE, 3
Feb 25 22:34:17.837092 switch120 NOTICE swss#orchagent: :- bake: Add warm input: BUFFER_QUEUE, 3
Feb 25 22:34:17.837687 switch120 ERR swss#orchagent: :- main: Failed due to exception: stoul
Feb 25 22:34:17.841919 switch120 INFO kernel: [ 35.606307] traps: orchagent[3721] general protection ip:49c16c sp:7ffde2755580 error:0
Feb 25 22:34:17.841922 switch120 WARNING kernel: [ 35.606312] in orchagent[400000+151000]
Feb 25 22:34:18.844587 switch120 INFO swss.sh[2027]: 2019-02-25 22:34:18,843 INFO success: buffermgrd entered RUNNING state, process has stayed up for > than 1 seconds (startsecs)
How I verified it
Reproduced the condition (PortConfigDone not set) and verified the fix.
Logs from after the fix::
Feb 26 01:23:36.621760 switch120 NOTICE swss#orchagent: :- bake: Add warm input: BUFFER_PROFILE, 3
Feb 26 01:23:36.621854 switch120 NOTICE swss#orchagent: :- bake: Add warm input: BUFFER_QUEUE, 3
Feb 26 01:23:36.621905 switch120 NOTICE swss#orchagent: :- bake: foundPortConfigDone = 0
Feb 26 01:23:36.621959 switch120 NOTICE swss#orchagent: :- bake: foundPortInitDone = 0
Feb 26 01:23:36.622021 switch120 NOTICE swss#orchagent: :- bake: m_portTable->getKeys 0
Feb 26 01:23:36.622021 switch120 NOTICE swss#orchagent: :- bake: No port table, fallback to cold start
Feb 26 01:23:36.622175 switch120 NOTICE swss#orchagent: :- bake: Add warm input: INTF_TABLE, 0
Feb 26 01:23:36.622297 switch120 NOTICE swss#orchagent: :- bake: Add warm input: NEIGH_TABLE, 0
Details if related