[intfsorch]:add support to change rif mac address #814

shine4chen · 2019-03-11T07:03:01Z

What I did
add support to change rif mac address

Why I did it
some apps such as mclag or vrrp need to change rif mac address

How I verified it
test it on nephos lab

Details if related

pull from origin

Signed-off-by: shine.chen <shine.chen@nephosinc.com>

prsunny

"mac_addr" is not a field currently in the INTF_TABLE/INTERFACE_TABLE. This needs to be defined in the schema and also require corresponding change in interface manager

orchagent/intfsorch.cpp

lguohan · 2019-04-21T22:01:22Z

need virtual switch test.

lguohan · 2019-04-21T22:04:59Z

@prsunny , I assume this can only be on rif without ip address. We can not set mac address for interface entry with IP address since we only create one rif for all ip addresses on that rif?

jianjundong · 2019-04-26T03:17:28Z

@prsunny , I assume this can only be on rif without ip address. We can not set mac address for interface entry with IP address since we only create one rif for all ip addresses on that rif?

In mclag, the ip address of mclag enabled portchannel of two peers must be the same, thus the mac address of rifs also must be the same.

jianjundong · 2019-04-26T07:55:56Z

"mac_addr" is not a field currently in the INTF_TABLE/INTERFACE_TABLE. This needs to be defined in the schema and also require corresponding change in interface manager

'mac_addr' is set as a field of INTF_TABLE in APP_DB currently. It is set by iccpd through mclagsyncd. This field may also be set as a field of INTERFACE_TABLE in CFG_DB and processed by intfmgrd? Thanks.

shine4chen · 2019-04-26T08:46:39Z

need virtual switch test.

sure, we will add it soon

shine4chen · 2019-04-26T09:08:33Z

need virtual switch test.

@lguohan Can you give us example or URL how to connect virtual switch test to specific PR

Signed-off-by: leo.li <leo.li@nephosinc.com>

shine4chen · 2019-06-04T09:02:48Z

@lguohan even for the interface associated with the ip address we still can/need to change its src-mac.

shine4chen · 2019-06-04T09:07:08Z

@prsunny Per our discussion on VRF, src-mac attribute should be put on {INTERFACE:Ethernetx} entry. I suggest we merge this PR to VRF code. How about your opinion?

lguohan · 2019-06-04T12:36:31Z

@shine4chen , thanks for adding vs test, but the added two tests are failing, can you investigate the failure.

stcheng

please check the comments.

one more question, will you support remove the source MAC address once it is set?

orchagent/intfsorch.cpp

tests/test_intf_mac.py

Signed-off-by: leo.li <leo.li@nephosinc.com>

leoli-nps · 2019-06-14T07:36:06Z

The vstest has been updated, please review. Thanks!

shine4chen · 2019-06-18T02:49:24Z

@stcheng @prsunny we have refined code according to your suggestion. Pls help to review it. Thanks.

Signed-off-by: shine.chen <shine.chen@nephosinc.com>

prsunny · 2019-07-08T23:08:40Z

@prsunny Per our discussion on VRF, src-mac attribute should be put on {INTERFACE:Ethernetx} entry. I suggest we merge this PR to VRF code. How about your opinion?

@shine4chen , yes I agree. I think you've made the changes based on this assumption currently correct?. If so, the change must be in doIntfGeneralTask and not in doIntfAddrTask in intfmgr.cpp. Can you please check?

tests/test_intf_mac.py

Signed-off-by: leo.li <leo.li@nephosinc.com>

shine4chen · 2019-07-09T10:49:30Z

@prsunny Per our discussion on VRF, src-mac attribute should be put on {INTERFACE:Ethernetx} entry. I suggest we merge this PR to VRF code. How about your opinion?

@shine4chen , yes I agree. I think you've made the changes based on this assumption currently correct?. If so, the change must be in doIntfGeneralTask and not in doIntfAddrTask in intfmgr.cpp. Can you please check?
@prsunny yes, We will move the change to doIntfGeneralTask function.

…-change-mac

Signed-off-by: shine.chen <shine.chen@nephosinc.com>

…swss into rif-change-mac

prsunny · 2019-11-22T17:56:47Z

retest this please

shine4chen · 2019-11-23T01:00:18Z

retest this please

shine4chen · 2019-11-27T09:57:45Z

retest this please

shine4chen · 2019-11-28T02:33:54Z

retest this please

shine4chen · 2019-11-28T16:45:00Z

retest this please

cfgmgr/intfmgr.cpp

orchagent/intfsorch.cpp

merge master branch

orchagent/intfsorch.cpp

Signed-off-by: shine.chen <shine.chen@mediatek.com>

shine4chen · 2019-12-01T14:08:12Z

retest this please

shine4chen · 2019-12-01T16:21:02Z

retest this please

shine4chen · 2019-12-02T13:33:40Z

retest this please

shine4chen · 2020-02-03T03:22:58Z

@stcheng @prsunny @adyeung I resolved some conflict. It seems system automatically dismissed your approve. Would you please to review and approve it?

Merge pull request #1 from Azure/master

9326978

pull from origin

shine4chen changed the title ~~Rif change mac~~ [intfsorch]:add support to change rif mac address Mar 11, 2019

[intfsorch]: add support to change rif mac-address

7796b10

Signed-off-by: shine.chen <shine.chen@nephosinc.com>

shine4chen force-pushed the rif-change-mac branch from b08bf36 to 7796b10 Compare March 19, 2019 09:06

prsunny reviewed Apr 20, 2019

View reviewed changes

orchagent/intfsorch.cpp Outdated Show resolved Hide resolved

orchagent/intfsorch.cpp Outdated Show resolved Hide resolved

add the corresponding vs-test

af68d10

Signed-off-by: leo.li <leo.li@nephosinc.com>

stcheng suggested changes Jun 4, 2019

View reviewed changes

stcheng added the Enhancement ➕ label Jun 4, 2019

[vstest] update the corresponding vstest for pr#814

2da2d4a

Signed-off-by: leo.li <leo.li@nephosinc.com>

shine.chen added 2 commits June 17, 2019 19:51

refine code according to prsunny/stcheng review

115f9aa

Signed-off-by: shine.chen <shine.chen@nephosinc.com>

fix bool value condition judgement

065c10f

Signed-off-by: shine.chen <shine.chen@nephosinc.com>

stcheng reviewed Jul 8, 2019

View reviewed changes

tests/test_intf_mac.py Outdated Show resolved Hide resolved

stcheng suggested changes Jul 8, 2019

View reviewed changes

tests/test_intf_mac.py Outdated Show resolved Hide resolved

[vstest] update the corresponding vstest for pr#814

dfcae9b

Signed-off-by: leo.li <leo.li@nephosinc.com>

shine.chen added 3 commits July 9, 2019 03:56

Merge branch 'master' of https://github.com/Azure/sonic-swss into rif…

d6fbb23

…-change-mac

move mac-address change code to intfGeneralTask

4b26a95

Signed-off-by: shine.chen <shine.chen@nephosinc.com>

Merge branch 'rif-change-mac' of https://github.com/shine4chen/sonic-…

76fa655

…swss into rif-change-mac

prsunny previously approved these changes Nov 22, 2019

View reviewed changes

stcheng previously approved these changes Nov 26, 2019

View reviewed changes

wendani reviewed Nov 29, 2019

View reviewed changes

cfgmgr/intfmgr.cpp Show resolved Hide resolved

orchagent/intfsorch.cpp Outdated Show resolved Hide resolved

shine4chen added 3 commits November 30, 2019 19:40

set {mac:""} to app-db if not existed in cfg-db

405f413

move mac variable definition down

5484fe0

Merge pull request #4 from Azure/master

9bd1b17

merge master branch

shine4chen force-pushed the rif-change-mac branch 3 times, most recently from 39e087f to 7143b94 Compare December 1, 2019 06:54

wendani reviewed Dec 1, 2019

View reviewed changes

orchagent/intfsorch.cpp Outdated Show resolved Hide resolved

add some sleep on test case

eff6af9

Signed-off-by: shine.chen <shine.chen@mediatek.com>

shine4chen force-pushed the rif-change-mac branch from 7143b94 to eff6af9 Compare December 1, 2019 09:07

Merge branch 'master' into rif-change-mac

7283a4c

shine4chen dismissed stale reviews from stcheng, prsunny, and adyeung via 7283a4c February 3, 2020 03:14

shine4chen requested a review from prsunny February 4, 2020 09:19

prsunny approved these changes Feb 12, 2020

View reviewed changes

prsunny merged commit 853d822 into sonic-net:master Feb 12, 2020

oleksandrivantsiv pushed a commit to oleksandrivantsiv/sonic-swss that referenced this pull request Mar 1, 2023

[vslib] Refresh queue pause status (sonic-net#814)

0372615

assafho mentioned this pull request Mar 15, 2023

[yang] interface yang model is missing mac_addr key sonic-net/sonic-buildimage#14253

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[intfsorch]:add support to change rif mac address #814

[intfsorch]:add support to change rif mac address #814

shine4chen commented Mar 11, 2019

prsunny left a comment

lguohan commented Apr 21, 2019

lguohan commented Apr 21, 2019

jianjundong commented Apr 26, 2019

jianjundong commented Apr 26, 2019

shine4chen commented Apr 26, 2019

shine4chen commented Apr 26, 2019

shine4chen commented Jun 4, 2019

shine4chen commented Jun 4, 2019

lguohan commented Jun 4, 2019

stcheng left a comment

leoli-nps commented Jun 14, 2019

shine4chen commented Jun 18, 2019

prsunny commented Jul 8, 2019

shine4chen commented Jul 9, 2019

prsunny commented Nov 22, 2019

shine4chen commented Nov 23, 2019

shine4chen commented Nov 27, 2019

shine4chen commented Nov 28, 2019

shine4chen commented Nov 28, 2019

shine4chen commented Dec 1, 2019

shine4chen commented Dec 1, 2019

shine4chen commented Dec 2, 2019

shine4chen commented Feb 3, 2020 •

edited

Loading

[intfsorch]:add support to change rif mac address #814

[intfsorch]:add support to change rif mac address #814

Conversation

shine4chen commented Mar 11, 2019

prsunny left a comment

Choose a reason for hiding this comment

lguohan commented Apr 21, 2019

lguohan commented Apr 21, 2019

jianjundong commented Apr 26, 2019

jianjundong commented Apr 26, 2019

shine4chen commented Apr 26, 2019

shine4chen commented Apr 26, 2019

shine4chen commented Jun 4, 2019

shine4chen commented Jun 4, 2019

lguohan commented Jun 4, 2019

stcheng left a comment

Choose a reason for hiding this comment

leoli-nps commented Jun 14, 2019

shine4chen commented Jun 18, 2019

prsunny commented Jul 8, 2019

shine4chen commented Jul 9, 2019

prsunny commented Nov 22, 2019

shine4chen commented Nov 23, 2019

shine4chen commented Nov 27, 2019

shine4chen commented Nov 28, 2019

shine4chen commented Nov 28, 2019

shine4chen commented Dec 1, 2019

shine4chen commented Dec 1, 2019

shine4chen commented Dec 2, 2019

shine4chen commented Feb 3, 2020 • edited Loading

shine4chen commented Feb 3, 2020 •

edited

Loading