Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[VLAN] Add pytest cases to validate different use-case of tagging_mode. #860

Merged
merged 7 commits into from
Aug 2, 2019

Conversation

linemma
Copy link
Contributor

@linemma linemma commented Apr 26, 2019

What I did
Add pytest cases to validate different use-case of tagging_mode.

Why I did it

How I verified it
Test cases:

  1. Input normal configuration to verify that:
  • the configuration shall be succeed
  • the value in asic database shall be expected
  1. Input invalid configuration to verify that:
  • the configuration shall be failed
  • the entry shall not existed in asic database
  1. Verify default value:
  • the default tagging_mode shall be "untagged"

Details if related

Signed-off-by: Emma Lin emma_lin@edge-core.com

Signed-off-by: Emma Lin <emma_lin@edge-core.com>
@linemma linemma force-pushed the add_pytest_cases_tagging_mode branch from 598f878 to 05e1e99 Compare May 13, 2019 07:48
@lguohan
Copy link
Contributor

lguohan commented May 20, 2019

@linemma , can you resolve conflict?

@linemma
Copy link
Contributor Author

linemma commented May 21, 2019

@lguohan, done. Please review the modification, thanks.

@linemma
Copy link
Contributor Author

linemma commented May 29, 2019

retest this please

@lguohan
Copy link
Contributor

lguohan commented Aug 1, 2019

can you resolve the conflict?

@linemma
Copy link
Contributor Author

linemma commented Aug 1, 2019

@lguohan, resolved, please review. Thanks.

@lguohan
Copy link
Contributor

lguohan commented Aug 1, 2019

can you do a rebase so that I can see the exact your changes?

@linemma
Copy link
Contributor Author

linemma commented Aug 1, 2019

Sorry, I don't understand. Could you tell me what should I do?

@linemma
Copy link
Contributor Author

linemma commented Aug 2, 2019

@lguohan, I fix some problem this morning, please review the modification. I will resolve the conflict on #875 after this PR merged. Thanks!

@lguohan lguohan merged commit 51393a2 into sonic-net:master Aug 2, 2019
oleksandrivantsiv pushed a commit to oleksandrivantsiv/sonic-swss that referenced this pull request Mar 1, 2023
Signed-off-by: Andriy Kokhan <andriyx.kokhan@intel.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants