Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[vstest]: Add test_port_config.py which include breakout port test. #866

Merged
merged 3 commits into from
Aug 2, 2019
Merged

[vstest]: Add test_port_config.py which include breakout port test. #866

merged 3 commits into from
Aug 2, 2019

Conversation

chiourung
Copy link
Contributor

@chiourung chiourung commented Apr 30, 2019

[pytests] Add test_port_config.py which include breakout port test.

It needs to modify sai_create_port for virtual switch.

What I did
add test case for port breakout

Why I did it
make sure the orchagent is correct for port breakout

How I verified it
run the pytest

Details if related
It also needs to modify sai_create_port for virtual switch (sonic-net/sonic-sairedis#453)

Signed-off-by: chiourung_huang chiourung_huang@edge-core.com

[pytests] Add test_port_config.py which include breakout port test.

It needs to modify sai_create_port for virtual switch.
@chiourung
Copy link
Contributor Author

chiourung commented Apr 30, 2019

The test_port_breakout needs to merge the commit in sonic-sairedis. (sonic-net/sonic-sairedis#453)
After merge (sonic-net/sonic-sairedis#453), it can pass the test_port_breakout.

@chiourung chiourung changed the title Signed-off-by: chiourung_huang <chiourung_huang@edge-core.com> [pytests] Add test_port_config.py which include breakout port test. May 3, 2019
@chiourung
Copy link
Contributor Author

retest this please

3 similar comments
@chiourung
Copy link
Contributor Author

retest this please

@chiourung
Copy link
Contributor Author

retest this please

@chiourung
Copy link
Contributor Author

retest this please

@chiourung
Copy link
Contributor Author

@lguohan , May you help to review? Thanks.

Copy link
Contributor

@stcheng stcheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please fix.

tests/test_port_config.py Show resolved Hide resolved
@lguohan
Copy link
Contributor

lguohan commented Jun 19, 2019

retest this please

@stcheng
Copy link
Contributor

stcheng commented Jul 16, 2019

retest this please

1 similar comment
@chiourung
Copy link
Contributor Author

retest this please

@stcheng
Copy link
Contributor

stcheng commented Jul 19, 2019

Retest this please

1 similar comment
@chiourung
Copy link
Contributor Author

Retest this please

@stcheng stcheng changed the title [pytests] Add test_port_config.py which include breakout port test. [portsorch]: Add port breakout support for VS and related VS tests Jul 24, 2019
@lguohan
Copy link
Contributor

lguohan commented Aug 1, 2019

retest this please

@lguohan lguohan changed the title [portsorch]: Add port breakout support for VS and related VS tests [vstest]: Add test_port_config.py which include breakout port test. Aug 1, 2019
@lguohan lguohan merged commit 6301abe into sonic-net:master Aug 2, 2019
EdenGri pushed a commit to EdenGri/sonic-swss that referenced this pull request Feb 28, 2022
oleksandrivantsiv pushed a commit to oleksandrivantsiv/sonic-swss that referenced this pull request Mar 1, 2023
Signed-off-by: kcudnik <kcudnik@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants