Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reorder dependencies to fix wheel build #117

Merged
merged 1 commit into from
Oct 4, 2017
Merged

Reorder dependencies to fix wheel build #117

merged 1 commit into from
Oct 4, 2017

Conversation

jleveque
Copy link
Contributor

@jleveque jleveque commented Oct 4, 2017

  • Dependencies listed in install_requires are installed in reverse order, so click-default-group must precede click

@jleveque jleveque self-assigned this Oct 4, 2017
@jleveque jleveque merged commit 2c63a41 into sonic-net:master Oct 4, 2017
@jleveque jleveque deleted the fix_wheel_build branch October 4, 2017 23:32
zhenggen-xu pushed a commit to zhenggen-xu/sonic-utilities that referenced this pull request Jun 6, 2018
Merge remote-tracking branch 'msft_github/master'
dc68199 
* msft_github/master:
  Reorder dependencies to fix wheel build (sonic-net#117)
vdahiya12 pushed a commit to vdahiya12/sonic-utilities that referenced this pull request Jul 23, 2021
@jleveque
[psud] Import of mock libraries determined by environment variable (s…
be21d91 
…onic-net#117)

Previously, psud assumed that the swsscommon library would not be installed in the unit testing environment. This is not a valid assumption, and would cause unit tests to fail if swsscommon was available in the unit test environment, because it would get imported, but there would be no Redis DB to communicate with.

This PR uses environment variables, which are set by the unit tests themselves, to determine whether to load the real or mock libraries. This solution is similar to what is done in sonic-utilities.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stcheng stcheng stcheng approved these changes

@lguohan lguohan Awaiting requested review from lguohan

@taoyl-ms taoyl-ms Awaiting requested review from taoyl-ms

Assignees

@jleveque jleveque

Labels
Enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jleveque @stcheng