Fast-reboot: add a new flag to ignore ASIC checksum verification failure #1292
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yxieca
approved these changes
Dec 7, 2020
Closed
3 tasks
anand-kumar-subramanian
pushed a commit
to anand-kumar-subramanian/sonic-utilities
that referenced
this pull request
Mar 2, 2021
…on failures (sonic-net#1292) To fix the issue sonic-net/sonic-buildimage#5972 warm-reboot with force flag ignores ASIC config checksum mismatch along with orchagent RESTARTCHECK failure. This commit accounts for a use case when checksum-verification should be ignored but orchagent pause check should not be ignored. The change is to add a new option in fast-reboot script to ignore ASIC checksum verification failures.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- What I did
This is to fix/enhance the issue sonic-net/sonic-buildimage#5972
warm-rebootwith force flag ignores ASIC config checksum mismatch along with orchagent RESTARTCHECK failure.There can be a use case when checksum-verification should be ignored but orchagent pause check should not be ignored.
- How I did it
Added a new
optionin fast-reboot script to ignore ASIC checksum verification failures.- How to verify it
Reproduced the issue locally:
With the local change ASIC configuration checksum verification is ignored.
- Previous command output (if the output of a command-line utility has changed)
- New command output (if the output of a command-line utility has changed)