[201911][acl-loader] Use 'ipaddress' module in lieu of 'ipaddr' #1484
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Should a corresponding change be made for 201811 branch too? That's where I have seen these tests to fail. |
vaibhavhd
approved these changes
Mar 5, 2021
|
Change is unnecessary in 201911 and cannot be ported exactly as is upstream due to differences between Python 2 and 3. Rather than add typecasting here, I will close this PR. We will continue to use 'ipaddr' in acl-loader in 201911. |
sflow
pushed a commit
to sflow/sonic-utilities
that referenced
this pull request
Feb 3, 2024
* added CLI: config sflow drop-monitor-limit 1-999 (0 to disable) * added line to show sflow output to indicate current setting * added test to ensure that out-of-range value is denied The effect is to add the redis field drop_monitor_limit to the sflow configuration table in redis, as described in pull-request sonic-net#1484 on the sonic-net/SONiC repo. Note: hsflowd version 2.0.52 will apply this setting. Older versions will ignore it. Signed-off-by: Neil McKee neil.mckee@inmon.com
sflow
added a commit
to sflow/sonic-utilities
that referenced
this pull request
Feb 5, 2024
* added CLI: config sflow drop-monitor-limit 1-999 (0 to disable) * added line to show sflow output to indicate current setting * added test to ensure that out-of-range value is denied The effect is to add the redis field drop_monitor_limit to the sflow configuration table in redis, as described in pull-request sonic-net#1484 on the sonic-net/SONiC repo. Note: hsflowd version 2.0.52 will apply this setting. Older versions will ignore it. Signed-off-by: Neil McKee neil.mckee@inmon.com
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Use 'ipaddress' module in lieu of 'ipaddr' in acl-loader.
This aligns acl-loader with all other sonic-utilities code in 201911 and aligns it with upstream modifications.
How I did it
Use 'ipaddress' module in lieu of 'ipaddr' in acl-loader.
How to verify it
Test acl-loader on 201911 branch.