Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Mellanox] Create sniffer folder if it doesn't exist yet #1659

Merged
merged 1 commit into from
Jun 20, 2021

Conversation

keboliu
Copy link
Collaborator

@keboliu keboliu commented Jun 9, 2021

What I did

following the change in PR sonic-net/sonic-buildimage#7830, the folder needs to be created when the first time enables the sniffer function.

How I did it

check whether the path to store the sniffer file is existing or not, if not, create it.

How to verify it

run command "config platform mlnx sniffer sdk enable", can see sniffer function can be enabled successfully.

Previous command output (if the output of a command-line utility has changed)

N/A

New command output (if the output of a command-line utility has changed)

N/A

@keboliu keboliu closed this Jun 11, 2021
@keboliu keboliu reopened this Jun 11, 2021
@keboliu keboliu closed this Jun 11, 2021
@keboliu keboliu reopened this Jun 11, 2021
@liat-grozovik
Copy link
Collaborator

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@keboliu keboliu closed this Jun 17, 2021
@keboliu keboliu reopened this Jun 17, 2021
@liat-grozovik
Copy link
Collaborator

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@liat-grozovik liat-grozovik merged commit a75a2e8 into sonic-net:master Jun 20, 2021
@keboliu keboliu deleted the sniffer-folder branch June 21, 2021 00:52
qiluo-msft pushed a commit that referenced this pull request Jul 13, 2021
- What I did
following the change in PR sonic-net/sonic-buildimage#7830, the folder needs to be created when the first time enables the sniffer function.

- How I did it
check whether the path to store the sniffer file is existing or not, if not, create it.

- How to verify it
run command "config platform mlnx sniffer sdk enable", can see sniffer function can be enabled successfully.
qiluo-msft pushed a commit to sonic-net/sonic-buildimage that referenced this pull request Jul 14, 2021
Update:
> 2ca493b 2021-07-13 create sniffer folder if not exist (sonic-net/sonic-utilities#1659) 
> 1695104 2021-07-07 [show priority-group drop counters] Remove backup with cached PG drop counters after 'config reload' (sonic-net/sonic-utilities#1679) 
> e99a3c5 2021-07-07 [show][config] support for interface alias for muxcable commands (sonic-net/sonic-utilities#1699)
raphaelt-nvidia pushed a commit to raphaelt-nvidia/sonic-utilities that referenced this pull request Aug 10, 2021
- What I did
following the change in PR sonic-net/sonic-buildimage#7830, the folder needs to be created when the first time enables the sniffer function.

- How I did it
check whether the path to store the sniffer file is existing or not, if not, create it.

- How to verify it
run command "config platform mlnx sniffer sdk enable", can see sniffer function can be enabled successfully.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants