-
Notifications
You must be signed in to change notification settings - Fork 678
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Load the database global_db only once for show cli #1712
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Arvindsrinivasan Lakshmi Narasimhan <arlakshm@microsoft.com>
Signed-off-by: Arvindsrinivasan Lakshmi Narasimhan <arlakshm@microsoft.com>
This pull request introduces 1 alert when merging edfe854 into 3f0b690 - view on LGTM.com new alerts:
|
Please fix lgtm new alert. In reply to: 879779594 |
Signed-off-by: Arvindsrinivasan Lakshmi Narasimhan <arlakshm@microsoft.com>
This pull request introduces 8 alerts when merging f02d26a into 0efd297 - view on LGTM.com new alerts:
|
This pull request introduces 7 alerts when merging 1669e9b into 0efd297 - view on LGTM.com new alerts:
|
/Azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
Signed-off-by: Arvindsrinivasan Lakshmi Narasimhan <arlakshm@microsoft.com>
5 tasks
qiluo-msft
approved these changes
Jul 20, 2021
qiluo-msft
pushed a commit
to sonic-net/sonic-buildimage
that referenced
this pull request
Aug 6, 2021
#### Why I did it Remove the call to `SonicDBConfig.load_sonic_global_db_config()` in the multi asic functions. The expection is the client calling this function will call `SonicDBConfig.load_sonic_global_db_config()` This PR is dependent on the PR sonic-net/sonic-utilities#1712 #### How to verify it compile sonic-utilities
judyjoseph
pushed a commit
that referenced
this pull request
Aug 7, 2021
Introduce a new function `load_db_config()`. This function will load the global database file or database config file based on the platform.
carl-nokia
pushed a commit
to carl-nokia/sonic-buildimage
that referenced
this pull request
Aug 7, 2021
#### Why I did it Remove the call to `SonicDBConfig.load_sonic_global_db_config()` in the multi asic functions. The expection is the client calling this function will call `SonicDBConfig.load_sonic_global_db_config()` This PR is dependent on the PR sonic-net/sonic-utilities#1712 #### How to verify it compile sonic-utilities
judyjoseph
pushed a commit
to sonic-net/sonic-buildimage
that referenced
this pull request
Sep 27, 2021
#### Why I did it Remove the call to `SonicDBConfig.load_sonic_global_db_config()` in the multi asic functions. The expection is the client calling this function will call `SonicDBConfig.load_sonic_global_db_config()` This PR is dependent on the PR sonic-net/sonic-utilities#1712 #### How to verify it compile sonic-utilities
ganglyu
pushed a commit
to sonic-net/sonic-host-services
that referenced
this pull request
Jul 12, 2022
#### Why I did it Remove the call to `SonicDBConfig.load_sonic_global_db_config()` in the multi asic functions. The expection is the client calling this function will call `SonicDBConfig.load_sonic_global_db_config()` This PR is dependent on the PR sonic-net/sonic-utilities#1712 #### How to verify it compile sonic-utilities
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Introduce a new function
load_db_config()
. This function will load the global database file or database config file based on the platform.This change depends on sonic-net/sonic-buildimage#8173
How I did it
How to verify it
UT results
Previous command output (if the output of a command-line utility has changed)
New command output (if the output of a command-line utility has changed)