check for unsupported speeds corrected #1946
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/azp run |
|
Commenter does not have sufficient privileges for PR 1946 in repo Azure/sonic-utilities |
|
/azpw run |
|
/AzurePipelines run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
@prsunny @zhangyanzhao @ganglyu |
|
@MaratGubaiev can you please fix conflict and add unit test to cover the check as well? |
It is already fixed here: #1952 |
stepanblyschak
pushed a commit
to stepanblyschak/sonic-utilities
that referenced
this pull request
Apr 18, 2022
Commits: f147d9e - 2021-10-27 : [Mux orch] Handle setting unknown mux state (sonic-net#1984) [Prince Sunny] 4618b2b - 2021-10-28 : Change tunnel orch order (sonic-net#1990) [Prince Sunny] 505d52d - 2021-10-20 : Fix the option missing in kernel config issue (sonic-net#1973) [xumia] 7bf4dfb - 2021-10-18 : SAI_REDIS_SWITCH_ATTR_CONTEXT shouldbe the last attribute. This is what sairedis library expects (sonic-net#1935) [judyjoseph] c58919e - 2021-10-08 : [logfile][202012]: Add option to specify swss rec file name (sonic-net#1946) [judyjoseph]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sonic-net/sonic-buildimage#9327 fixed
What I did
I changed string search to list search.
How I did it
How to verify it
Perform
sudo config interface speed Ethernet0 500You will see the error message.
Perform
show interfaces statusEthernet0 speed will remain unchanged.
Previous command output (if the output of a command-line utility has changed)
New command output (if the output of a command-line utility has changed)