Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for show vxlan tunnel command display issue #11902 #2391

Merged
merged 8 commits into from
Sep 30, 2022
Merged

Fix for show vxlan tunnel command display issue #11902 #2391

merged 8 commits into from
Sep 30, 2022

Conversation

skbhava
Copy link
Contributor

@skbhava skbhava commented Sep 20, 2022 •
edited
Loading

Fixes #11902

Issue:
Only one vni to vlan map entry in the output of show vxlan tunnel command even if multiple vni-vlan mapping exists
Fix:
Added fix to display all vni to vlan map entries for "show vxlan tunnel" and "show vxlan name " commands.

Following is the command output with 4 vlan-vni mappings.

Previous command output (if the output of a command-line utility has changed)

root@sonic:/home/admin# show vxlan tunnel 
vxlan tunnel name    source ip    destination ip    tunnel map name    tunnel map mapping(vni -> vlan)
-------------------  -----------  ----------------  -----------------  ---------------------------------
vtep1                1.1.1.1      2.2.2.2           map_100_Vlan100    100 -> Vlan100

root@sonic:/home/admin# show vxlan name vtep1
vxlan tunnel name    source ip    destination ip    tunnel map name    tunnel map mapping(vni -> vlan)
-------------------  -----------  ----------------  -----------------  ---------------------------------
vtep1                1.1.1.1      2.2.2.2           map_100_Vlan100    100 -> Vlan100

New command output (if the output of a command-line utility has changed)

root@sonic:/home/admin# show vxlan tunnel 
vxlan tunnel name    source ip    destination ip    tunnel map name    tunnel map mapping(vni -> vlan)
-------------------  -----------  ----------------  -----------------  ---------------------------------
vtep1                1.1.1.1      2.2.2.2           map_100_Vlan100    100 -> Vlan100
                                                    map_101_Vlan101    101 -> Vlan101
                                                    map_102_Vlan102    102 -> Vlan102
                                                    map_200_Vlan200    200 -> Vlan200
root@sonic:/home/admin# show vxlan name vtep1
vxlan tunnel name    source ip    destination ip    tunnel map name    tunnel map mapping(vni -> vlan)
-------------------  -----------  ----------------  -----------------  ---------------------------------
vtep1                1.1.1.1      2.2.2.2           map_100_Vlan100    100 -> Vlan100
                                                    map_101_Vlan101    101 -> Vlan101
                                                    map_102_Vlan102    102 -> Vlan102
                                                    map_200_Vlan200    200 -> Vlan200

@skbhava
Issue:
e8266bf 
Only one vni to vlan map entry in the output of show vxlan tunnel command Fix:
Fix:
Added fix to display all vni to vlan map entries for "show vxlan tunnel" and "show vxlan name commands.
@skbhava skbhava marked this pull request as ready for review September 20, 2022 20:21
@skbhava
Issue:
da93512 
Only one vni to vlan map entry in the output of show vxlan tunnel command
Fix:
Added fix to display all vni to vlan map entries for "show vxlan tunnel" and "show vxlan name commands.
@lgtm-com
Copy link

lgtm-com bot commented Sep 20, 2022

This pull request introduces 1 alert when merging e8266bf into 0a7557b - view on LGTM.com

new alerts:

  • 1 for Syntax error

@prsunny
Copy link
Contributor

prsunny commented Sep 23, 2022

Please provide the output of previous and new command. Please follow the template while creating PR

@prsunny prsunny requested a review from dgsudharsan September 23, 2022 22:00
@adyeung adyeung mentioned this pull request Sep 23, 2022
Closed
dgsudharsan
dgsudharsan suggested changes Sep 28, 2022
View reviewed changes
Copy link
Collaborator

@dgsudharsan dgsudharsan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add UT for coverage

@skbhava skbhava requested a review from dgsudharsan September 28, 2022 21:50
@skbhava
Copy link
Contributor Author

skbhava commented Sep 28, 2022

Please add UT for coverage

Added UT cases

@prsunny prsunny merged commit cb0edd3 into sonic-net:master Sep 30, 2022
yxieca pushed a commit that referenced this pull request Oct 3, 2022
@skbhava @yxieca
Fix for show vxlan tunnel command display issue #11902 (#2391)
f41e4d1 
* Issue: Only one vni to vlan map entry in the output of show vxlan tunnel command Fix:
Fix: Added fix to display all vni to vlan map entries for "show vxlan tunnel" and "show vxlan name commands.
EdenGri pushed a commit to EdenGri/sonic-utilities that referenced this pull request Oct 12, 2022
@skbhava @EdenGri
Fix for show vxlan tunnel command display issue #11902 (sonic-net#2391)
1d981fd 
* Issue: Only one vni to vlan map entry in the output of show vxlan tunnel command Fix:
Fix: Added fix to display all vni to vlan map entries for "show vxlan tunnel" and "show vxlan name commands.
mdanish-kh pushed a commit to hamnarauf/sonic-utilities that referenced this pull request Oct 22, 2022
@skbhava @mdanish-kh
Fix for show vxlan tunnel command display issue #11902 (sonic-net#2391)
19635f5 
* Issue: Only one vni to vlan map entry in the output of show vxlan tunnel command Fix:
Fix: Added fix to display all vni to vlan map entries for "show vxlan tunnel" and "show vxlan name commands.
preetham-singh pushed a commit to preetham-singh/sonic-utilities that referenced this pull request Nov 21, 2022
@skbhava @preetham-singh
Fix for show vxlan tunnel command display issue #11902 (sonic-net#2391)
8ee5768 
* Issue: Only one vni to vlan map entry in the output of show vxlan tunnel command Fix:
Fix: Added fix to display all vni to vlan map entries for "show vxlan tunnel" and "show vxlan name commands.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prsunny prsunny prsunny approved these changes

@dgsudharsan dgsudharsan dgsudharsan approved these changes

Assignees
No one assigned
Labels
Included in 202205 Branch Request for 202205 Branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@skbhava @prsunny @dgsudharsan @yxieca