[decode-syseeprom] Optimize platform info fetch #276
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Andriy Moroz <c_andriym@mellanox.com>
lguohan
approved these changes
Jun 26, 2018
lguohan
pushed a commit
that referenced
this pull request
Oct 13, 2018
Signed-off-by: Andriy Moroz <c_andriym@mellanox.com>
madhupalu
added a commit
to madhupalu/sonic-utilities
that referenced
this pull request
Jan 18, 2019
madhupalu
added a commit
to madhupalu/sonic-utilities
that referenced
this pull request
Feb 17, 2019
…annel' and Suffix 'xxxx' (sonic-net#276) Signed-off-by: madhu Pal <madhupa@aviznetworks.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Andriy Moroz c_andriym@mellanox.com
- What I did
Updated decode-syseeprom utility to directly use sonic_platform module for getting platform name instead of running sonic-cfggen
- How I did it
imported needed functions from sonic_platform
- How to verify it
run decode-syseeprom -m to see it still able to fetch MAC
It also works faster
0.1s versus 0.3s