Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GCU Feature Update] Cherry-pick Platform Validator PR to 202205 #2883

Merged
merged 3 commits into from
Jun 23, 2023

Conversation

isabelmsft
Copy link
Contributor

@isabelmsft isabelmsft commented Jun 19, 2023

ADO 17747379

This PR cherry-picks three PRs to 202205 in the following order:

  1. [GCU] Add Sample Unit Test for RDMA Headroom Pool Size Tuning #2692
  2. Add GCU UT Coverage #2818
  3. Complete Platform Validator PR #2857.

Motivation of cherry-pick is to add PR #2857 platform validator functionality to 202205. Without this PR, GCU does not have the ability to restrict updates to certain tables based on platform. This function is necessary for RDMA related tables. This platform validator PR uses a test file created and updated in PR #2692 and PR #2818, so all three PRs are cherry-picked together.

After this PR is merged, the sonic-mgmt test cases need to be updated: sonic-net/sonic-mgmt#8583

…net#2692)

* add rdma gcu unit test

* fix comment

* clean unused code

* clean format

* extend to mock patchapplier, in place of changeapplier

* replace tabs with spaces
Add GCU UT coverage to ensure each step of patch sorting is valid
Cherry-pick PR 2692, 2818, and 2857 to 202205
@qiluo-msft qiluo-msft requested a review from yxieca June 21, 2023 21:11
@yxieca yxieca merged commit 436ecb0 into sonic-net:202205 Jun 23, 2023
isabelmsft added a commit to isabelmsft/sonic-utilities that referenced this pull request Jul 12, 2023
yxieca pushed a commit that referenced this pull request Jul 12, 2023
isabelmsft added a commit to isabelmsft/sonic-utilities that referenced this pull request Aug 10, 2023
…ic-net#2883)

* [GCU] Complete RDMA Platform Validator PR (sonic-net#2857)
Cherry-pick PR 2692, 2818, and 2857 to 202205
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants