Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[VOQ][saidump] Modify generate_dump: replace save_saidump with save_saidump_by_route_size #2972

Merged
merged 12 commits into from
Nov 15, 2023
Merged

[VOQ][saidump] Modify generate_dump: replace save_saidump with save_saidump_by_route_size #2972

Changes from 5 commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
2b43852
* [saidump]
JunhongMao Sep 1, 2023
62aab2d
* [saidump]
JunhongMao Sep 1, 2023
5ecb3c1
Merge branch 'master' of github.com:JunhongMao/sonic-utilities
JunhongMao Sep 1, 2023
3504fdc
* [saidump]
JunhongMao Sep 5, 2023
2450c48
* [saidump]
JunhongMao Sep 6, 2023
9fa769e
Fixup based on the below PR comments.
JunhongMao Sep 19, 2023
8a3f93b
According to the testing group's advice, change the default ROUTE_TAB…
JunhongMao Sep 20, 2023
32f5607
https://github.com/sonic-net/sonic-buildimage/pull/16466 fixing based…
JunhongMao Sep 30, 2023
64ad586
Merge remote-tracking branch 'upstream/master'
JunhongMao Oct 3, 2023
867a6d1
To address the below review comments:
JunhongMao Oct 4, 2023
185bfef
Merge remote-tracking branch 'upstream/master'
JunhongMao Oct 4, 2023
86d3efa
Merge remote-tracking branch 'upstream/master'
JunhongMao Oct 12, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 23 additions & 0 deletions scripts/generate_dump
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -883,6 +883,27 @@ save_saidump() {
fi
}

###############################################################################
# SAI DUMP from syncd by Redis Save command
# Globals:
# NUM_ASICS
# Arguments:
# None
# Returns:
# None
###############################################################################
save_saidump_by_redis_save_cmd() {
trap 'handle_error $? $LINENO' ERR
if [[ ( "$NUM_ASICS" == 1 ) ]] ; then
save_cmd "saidump.sh" "saidump"
else
for (( i=0; i<$NUM_ASICS; i++ ))
do
save_cmd "saidump.sh $i" "saidump$i"
done
fi
}

###############################################################################
# Save platform related info
# Globals:
Expand Down Expand Up @@ -1791,6 +1812,8 @@ main() {

if [[ "$device_type" != "SpineRouter" ]]; then
save_saidump
else
save_saidump_by_redis_save_cmd
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i do not feel we should check device_type, and doing different saidump based on the device type. Can you check the asic db size and if it is larger than xxx entries, then we do the new way?

Copy link
Contributor Author

@JunhongMao JunhongMao Sep 19, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lguohan, please help to review my updates. The variable ROUTE_TAB_LIMIT_DIRECT_ITERATION with default value 24000.

fi

if [ "$asic" = "barefoot" ]; then
Expand Down