-
Notifications
You must be signed in to change notification settings - Fork 669
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix for GCU_DHCP_Relay KVM test Failure in HEAD PR #2990
Closed
Closed
Changes from all commits
Commits
Show all changes
78 commits
Select commit
Hold shift + click to select a range
330b101
Modification of Vlan.py and creation of switchport.py
MuhammadUmarAsad d4ba163
Added range functionality in '-m' flag and removed explicit range com…
MuhammadUmarAsad 0ddb795
Merge branch 'PR_Saved' of https://github.com/ridahanif96/sonic-utili…
MuhammadUmarAsad 6b3ac13
Merge branch 'PR_Saved' of https://github.com/ridahanif96/sonic-utili…
MuhammadUmarAsad 930630c
Modified switchport.py functionality removing default Vlan from it
MuhammadUmarAsad fa5d756
Merge branch 'sonic-net:master' into master
MuhammadUmarAsad 02b1e8a
Modification in vlan.py and switchport.py
MuhammadUmarAsad cd13da3
Added support for mode attribute in IP config commands and updated the
MuhammadUmarAsad 519324d
Added switchport mode support for PORTCHANNEL
MuhammadUmarAsad 0ca0d24
changed echo statement to error statement in switchport
MuhammadUmarAsad 5fea7b8
Merge branch 'master' into master
MuhammadUmarAsad 2fd4c09
updated the merge conflicts
MuhammadUmarAsad 22888f1
Resolved Merge Conflicts with #2669
MuhammadUmarAsad 99609dd
Resolved Merge Conflicts with PR #2669
MuhammadUmarAsad 4176fec
Updated test cases w.r.t to PR#2669
MuhammadUmarAsad b4e46db
Updated db_migrator.py for switchport mode
MuhammadUmarAsad 6ea6025
updating db_migrator for switchport mode
MuhammadUmarAsad a007d20
Merge branch 'master' into master
MuhammadUmarAsad d77508f
fixing db_migrator
MuhammadUmarAsad d64ddd6
Merge branch 'master' of https://github.com/ridahanif96/sonic-utiliti…
MuhammadUmarAsad 5a18655
db_migrator
MuhammadUmarAsad 499b6d5
changes in db migrator for switchport
MuhammadUmarAsad 63e28aa
fixing migrate_config_db_port_table_for_switchport_mode
MuhammadUmarAsad b4197b9
updated migrate_config_db_port_table_for_switchport_mode to migrate_c…
MuhammadUmarAsad 0df0f34
plans to handle DHCP restart service after its conflicts ends with ya…
MuhammadUmarAsad 8bc5493
updated config vlan del command for DHCP relay restart services since…
MuhammadUmarAsad 046fc2e
added testcases for switchport mode in db_migrator
MuhammadUmarAsad 92f8a2c
updated input and expected output for switchport db_migrator
MuhammadUmarAsad dd4828a
updated db_migrator tests for switchport mode with PORTCHANNEL input …
MuhammadUmarAsad 478a3a6
updated test db_migrator and switchport expedted output
MuhammadUmarAsad c5a1ea1
db_migrator test cases
MuhammadUmarAsad 9547b95
Revert "db_migrator test cases"
MuhammadUmarAsad f7bc359
testing db_migrator.py
MuhammadUmarAsad d856425
testing db_migrator.py
MuhammadUmarAsad 6861d63
testing db_migrator.py
MuhammadUmarAsad 1458610
updated db_migrator switchport mode test and inputs/outputs
MuhammadUmarAsad ae00297
db_migrator switchport test update
MuhammadUmarAsad 5ccc73b
db_migrator updated switchport migration and updated DB_VERSION
MuhammadUmarAsad ddabf32
db_migrator test
MuhammadUmarAsad 9411196
updated db_migrator tests
MuhammadUmarAsad c3fab6d
updated db_migrator switchport test input config
MuhammadUmarAsad da65f41
updated db_migrator switchport mode input and expected output
MuhammadUmarAsad 4c03ff1
updated db_migrator switchport mode test input and output
MuhammadUmarAsad e347a61
updated migrate_config_db_switchport_mode in db_migrator and updated …
MuhammadUmarAsad 43d7b05
Merge branch 'master' into master
MuhammadUmarAsad 55dbfb3
updated the db_migrator and vlan.py for merge conflicts and removed p…
MuhammadUmarAsad f4b130c
updated vlan test cases. Removed Assertion of vlan addition|deletion …
MuhammadUmarAsad e980471
removed print asserrtion vlan member addition statement from test cases
MuhammadUmarAsad 1836cd8
removed print asserrtion vlan member deletion statement from test cases
MuhammadUmarAsad 7998123
removed some leftover print asserrtion vlan member deletion statement…
MuhammadUmarAsad 485b4c8
updating of code with regards to the changed in HLD
MuhammadUmarAsad 2273103
removed extra error message from vlan.py config
MuhammadUmarAsad ba7b72d
Merge branch 'master' into master
MuhammadUmarAsad 57f1c99
Merge branch 'master' of https://github.com/ridahanif96/sonic-utiliti…
MuhammadUmarAsad 70cbfe5
fixed indentation errors
MuhammadUmarAsad ebc14ca
indentation fix
MuhammadUmarAsad 5b1063c
updated -e flag for config vlan member add/del in command reference
MuhammadUmarAsad 3faca88
Merge branch 'master' into master
MuhammadUmarAsad 7177585
Merge branch 'master' into master
MuhammadUmarAsad 2672a99
fixed indentation error in db_migrator.py
MuhammadUmarAsad f87a7e7
added missing handling log info in verson_4_0_1
MuhammadUmarAsad 7ccb817
running pipelines
MuhammadUmarAsad 43a5e17
added pass statement instead of error when running switchport mode co…
MuhammadUmarAsad 76b4f81
updated test case for switchport mode
MuhammadUmarAsad a70fd53
Merge branch 'master' into master
MuhammadUmarAsad cba8e2e
running pipelines
MuhammadUmarAsad dd11b3c
Merge branch 'sonic-net:master' into master
MuhammadUmarAsad 300b353
Merge branch 'master' into master
MuhammadUmarAsad 95912ba
fixed space/tab indent usage error
MuhammadUmarAsad f63f960
spacing
MuhammadUmarAsad 7b7fd96
pipeline trigger
MuhammadUmarAsad 6d67b53
pipeline trigger
MuhammadUmarAsad 68b1b5f
Merge branch 'sonic-net:master' into master
ridahanif96 a20aa33
Merge branch 'sonic-net:master' into master
ridahanif96 6aec2b5
Fix for GCU_DHCP_Relay KVM Failure
ridahanif96 5d912d8
Fix for Commits
ridahanif96 c406fb8
fix for commits and failure
ridahanif96 65bfed9
Fix indentation
ridahanif96 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you want to use
self.switchport_mode_remove
?Please check test failure:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@qiluo-msft , Yes i want to remove "mode" attribute for this created this self.switchport_mode_remove function. All these test failures has been resolved and updated in new PR: #2993. Please consider this new one.