Migrate AAA table in db_migrator #3284
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/AzurePipelines run Azure.sonic-utilities |
|
Azure Pipelines successfully started running 1 pipeline(s). |
qiluo-msft
reviewed
Apr 27, 2024
scripts/db_migrator.py
Outdated
| return | ||
|
|
||
| authentication_config_old = self.configDB.get_entry('AAA', 'authentication') | ||
| # If device enabled TACACS authentication, then enable TACACS per-command accounting and authorization |
There was a problem hiding this comment.
The old image's enablement does not matter. As long as the required passkey is there, and intention is to enable, then we should enable.
There was a problem hiding this comment.
Fixed, also discussion with Gang about how to handle version, because AAA table should migrate on all version >= 202205, so add migrate to common_migration_ops.
qiluo-msft
reviewed
Apr 27, 2024
scripts/db_migrator.py
Outdated
| return | ||
|
|
||
| authentication_config_old = self.configDB.get_entry('AAA', 'authentication') | ||
| # If device enabled TACACS authentication, then enable TACACS per-command accounting and authorization |
There was a problem hiding this comment.
Fixed, this PR only contains migrate accounting part. will submit another PR later.
liuh-80
changed the title
ganglyu
previously approved these changes
Apr 29, 2024
qiluo-msft
previously approved these changes
Apr 29, 2024
ganglyu
approved these changes
Apr 29, 2024
|
Per-command authorization migrate code add in this PR: #3296 |
liuh-80
added a commit
to liuh-80/sonic-utilities
that referenced
this pull request
May 20, 2024
Migrate AAA table in db_migrator
per-command AAA need enable in warm-upgrade case
Add db_migrator code to migrate AAA table
Pass all test case.
Add new test case.
N/A
Migrate AAA table in db_migrator
mssonicbld
pushed a commit
to mssonicbld/sonic-utilities
that referenced
this pull request
May 21, 2024
Migrate AAA table in db_migrator
#### Why I did it
per-command AAA need enable in warm-upgrade case
#### How I did it
Add db_migrator code to migrate AAA table
#### How to verify it
Pass all test case.
Add new test case.
#### Which release branch to backport (provide reason below if selected)
N/A
#### Description for the changelog
Migrate AAA table in db_migrator
#### A picture of a cute animal (not mandatory but encouraged)
|
Cherry-pick PR to 202311: #3329 |
mssonicbld
pushed a commit
that referenced
this pull request
May 21, 2024
Migrate AAA table in db_migrator
#### Why I did it
per-command AAA need enable in warm-upgrade case
#### How I did it
Add db_migrator code to migrate AAA table
#### How to verify it
Pass all test case.
Add new test case.
#### Which release branch to backport (provide reason below if selected)
N/A
#### Description for the changelog
Migrate AAA table in db_migrator
#### A picture of a cute animal (not mandatory but encouraged)
mssonicbld
added
Included in 202311 Branch
and removed
Created PR to 202311 Branch
labels
arfeigin
pushed a commit
to arfeigin/sonic-utilities
that referenced
this pull request
Jun 16, 2024
Migrate AAA table in db_migrator
#### Why I did it
per-command AAA need enable in warm-upgrade case
#### How I did it
Add db_migrator code to migrate AAA table
#### How to verify it
Pass all test case.
Add new test case.
#### Which release branch to backport (provide reason below if selected)
N/A
#### Description for the changelog
Migrate AAA table in db_migrator
#### A picture of a cute animal (not mandatory but encouraged)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migrate AAA table in db_migrator
Why I did it
How I did it
How to verify it
Which release branch to backport (provide reason below if selected)
Description for the changelog
A picture of a cute animal (not mandatory but encouraged)