Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for sai debug generate dump #3556

Open
wants to merge 11 commits into
base: master
Choose a base branch
from

Conversation

aviramd
Copy link

@aviramd aviramd commented Sep 25, 2024

generating SAI debug dump file in show techsupport command and place it techsupport dump folder

It triggers the generation of a SAI debug dump file through Redis APPL DB.

An auxiliary script "gen_sai_dbg_dump.sh" is also provided to generate the dump file directly without requiring the show techsupport command.

HLD:
sonic-net/SONiC#1846

What I did

How I did it

How to verify it

Previous command output (if the output of a command-line utility has changed)

New command output (if the output of a command-line utility has changed)

This update introduces support for the sai_dbg_gen_dump API, which is triggered by the show techsupport command within the generate_dump script.
Currently, this API is only invoked in the vendor specific use case to avoid disrupting existing implementations for other vendors.
It is recommended to adopt this new procedure for triggering sai_dbg_gen_dump and eventually phase out the standalone saisdkdump executable.
By integrating this API directly within the process, we eliminate the need for a separate process, as not all SAI implementations will function correctly when the API is called from a different process other than syncd. Additionally, this change will reduce the system footprint by 70 MB, currently occupied by the saisdkdump executable.

An auxiliary script "gen_sai_dbg_dump.sh" is also provided to generate the dump file directly without requiring the show techsupport command.
Signed-off-by: aviramd <aviramd@marvell.com>
…sec)

Signed-off-by: aviramd <aviramd@marvell.com>
…sec)

Signed-off-by: aviramd <aviramd@marvell.com>
…sec)

Signed-off-by: aviramd <aviramd@marvell.com>
@aviramd aviramd force-pushed the SAI_DBG_GEN_DUMP_support branch from d240654 to 9893ebf Compare November 11, 2024 16:41
@mssonicbld
Copy link
Collaborator

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants