-
Notifications
You must be signed in to change notification settings - Fork 672
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SmartSwitch] Extend reboot script for rebooting SmartSwitch #3566
base: master
Are you sure you want to change the base?
Conversation
460146c
to
c72fbc0
Compare
8746356
to
d6fc624
Compare
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
hi @gpunathilell - may I ask the next steps required for this one please? |
HI @KrisNey-MSFT Testing is not done yet, as we have to integrate both PMON changes (some PRs are still pending merge and undergoing changes) and the Reboot HLD related changes (some PRs have merge conflicts with the PRs related to PMON changes)so takes time to create a test image and do some testing |
local dpu_ip=$1 | ||
local port=$2 | ||
local reboot_status | ||
reboot_status=$(docker exec -i gnmi gnoi_client -target "${dpu_ip}:${port}" -logtostderr -insecure -notls -rpc RebootStatus 2>/dev/null) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After the changes regarding -notls, the communication is fixed, but the command shows a different error
This command yields the following output:
panic: rpc error: code = Unknown desc = systemd: Invalid reboot method: 3
goroutine 1 [running]:
main.systemReboot({0xb2a918, 0xc0001e1da0}, {0xb273d8, 0xc000113ac0})```
Thank you!
From: Gagan Punathil Ellath ***@***.***>
Sent: Monday, January 27, 2025 10:25 AM
To: sonic-net/sonic-utilities ***@***.***>
Cc: Kristina Moore ***@***.***>; Mention ***@***.***>
Subject: Re: [sonic-net/sonic-utilities] [SmartSwitch] Extend reboot script for rebooting SmartSwitch (PR #3566)
hi @gpunathilell<https://github.com/gpunathilell> - may I ask the next steps required for this one please?
HI @KrisNey-MSFT<https://github.com/KrisNey-MSFT> Testing is not done yet, as we have to integrate both PMON changes (some PRs are still pending merge and undergoing changes) and the Reboot HLD related changes (some PRs have merge conflicts with the PRs related to PMON changes)so takes time to create a test image and do some testing
-
Reply to this email directly, view it on GitHub<#3566 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AFJSI6BEYDC3YPAADBY5WJL2MZ2XHAVCNFSM6AAAAABPKJS7IGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMMJWGU3TMOBTGI>.
You are receiving this because you were mentioned.Message ID: ***@***.******@***.***>>
|
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
Error seen with latest changes |
Also there are two issues which need to be addressed, the provisioning for the DPU and the switch GNMI container configuration (as these configurations are required to make sure that the gnoi_client command can be executed from the switch) |
Dependent upon PMON via Cisco, and a few Issues filed. |
What I did
Extended reboot script for SmartSwitch cases to reboot entire SmartSwitch or a specific DPU
How I did it
Implemented changes according to https://github.com/sonic-net/SONiC/blob/605c3a56ac2717dbbb638433e7bb13054fc05a31/doc/smart-switch/reboot/reboot-hld.md
How to verify it
Previous command output (if the output of a command-line utility has changed)
New command output (if the output of a command-line utility has changed)