[ARM64][Warm-Reboot]: Get boot arguments from uboot environment #3613
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marvellparthiv
force-pushed
the
master
branch
from
146bab1 to
e3017ba
Compare
Fetch boot arguments from the next boot image by reading it from uboot environment variables. Signed-off-by: Parthiv Shah <parthiv@marvell.com>
marvellparthiv
force-pushed
the
master
branch
from
e3017ba to
a80796a
Compare
|
@saiarcot895 Can you please review this. PR has been rebased to latest code. |
saiarcot895
approved these changes
Nov 20, 2024
|
@saiarcot895, kindly cherry-pick the patch to 202405 branch. |
|
@saiarcot895 before this is cherry picked, we need to cherry pick PR #3192 to resolve the conflict. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fetch boot arguments from the next boot image by reading it from uboot environment variables.
What I did
In current scenario, during warm-reboot for arm64, boot arguments are fetched from device tree of the current image. This causes an issue during upgrade/downgrade with warm-reboot.
How I did it
With the change, boot arguments for arm64 is fetched from uboot environment variables. The logic relies on creation of
"sonic_bootargs" environment variable to fetch the right boot argument.
How to verify it
Tested by sonic to sonic install followed by warm-reboot.
Previous command output (if the output of a command-line utility has changed)
New command output (if the output of a command-line utility has changed)