[show_tech] modify generate_dump to includes BERT data and also the platform specified hw-mgmt info #3676
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
mlok-nokia
force-pushed
the
show_tech_with_hwdump_and_sys
branch
from
c93af87 to
65214ee
Compare
…w-mgmt info Signed-off-by: mlok <marty.lok@nokia.com>
|
@judyjoseph and @arlakshm This PR modify the show_tech to include BERT info and also the platform specified hw-mgmt-generate_dump.sh. I have verified that. It works fine. Please review it |
anamehra
reviewed
Dec 18, 2024
| @@ -1582,6 +1619,25 @@ collect_broadcom() { | |||
|
|
|||
| copy_from_masic_docker "syncd" "/var/log/diagrun.log" "/var/log/diagrun.log" | |||
| copy_from_masic_docker "syncd" "/var/log/bcm_diag_post" "/var/log/bcm_diag_post" | |||
|
|
|||
| # run 'hw-management-generate-dump.sh' script and save the result file | |||
| HW_DUMP_FILE=/usr/bin/hw-management-generate-dump.sh | |||
There was a problem hiding this comment.
This PR should also cleanup the duplicate code in vendor specific functions, otherwise it will cause duplicate execution and increase run time.
There was a problem hiding this comment.
ignore, looks like being done only for broadcom.
Should we move it to common code?
The code gets executed only when vendor provide the executable.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Modify the generate_dump to include the BERT data and the platform specified hw-mgmt info
How I did it
How to verify it
Which release branch to backport (provide reason below if selected)
Previous command output (if the output of a command-line utility has changed)
New command output (if the output of a command-line utility has changed)