[mellanox|ffb] use system level warm reboot for Mellanox fastfast boot #413
Conversation
Signed-off-by: Stepan Blyschak <stepanb@mellanox.com>
scripts/fast-reboot
Outdated
| backup_datebase | ||
| # Warm reboot: dump state to host disk | ||
| if [[ "$REBOOT_TYPE" = "fastfast-reboot" ]]; then | ||
| redis-cli -n 1 FLUSHDB &> /dev/null |
There was a problem hiding this comment.
& [](start = 31, length = 1)
Do you intend to run the command in background? If yes, please also wait until all of them finished. #Closed
There was a problem hiding this comment.
&> is piping stdout and stderr together to some file, in this case /dev/null. It won't cause background execution.
scripts/fast-reboot
Outdated
| backup_datebase | ||
| # Warm reboot: dump state to host disk | ||
| if [[ "$REBOOT_TYPE" = "fastfast-reboot" ]]; then | ||
| redis-cli -n 1 FLUSHDB &> /dev/null |
There was a problem hiding this comment.
FLUSHDB [](start = 23, length = 7)
Similar flush code is in files files/scripts/{swss,syncd}.sh. Could you add your branch there? #Closed
There was a problem hiding this comment.
I did not put flush there because of two reasons
- if system warm restart flag is enabled and platform mellanox swss.sh flushes counters db so it will affect docker level swss restart
- I don't think there is need to backup something that will be flushed later
|
Thanks for muting these background outputs. There is one more at https://github.com/Azure/sonic-utilities/blob/b9c6840debc01b45c6a653fe605d2654481abccb/scripts/fast-reboot#L231, check_restart could also print something. Can you mute this call as well? Other than that, looks good to me. Thanks, |
Signed-off-by: Stepan Blyschak <stepanb@mellanox.com>
…wn requests Signed-off-by: Stepan Blyschak <stepanb@mellanox.com>
Signed-off-by: Stepan Blyschak <stepanb@mellanox.com>
Signed-off-by: Stepan Blyschak <stepanb@mellanox.com>
| @@ -163,27 +164,17 @@ case "$REBOOT_TYPE" in | |||
| REBOOT_TYPE="fastfast-reboot" | |||
There was a problem hiding this comment.
REBOOT_TYPE="fastfast-reboot" [](start = 12, length = 29)
We'd better treat fastfast-reboot as Mellanox implementation of warm-reboot, and keep REBOOT_TYPE as warm-reboot.
There was a problem hiding this comment.
it is a different flow and i think we should keep it different just in case warmboot will have flows which we should not use.
I prefer keeping it that way
Signed-off-by: Stepan Blyschak stepanb@mellanox.com
- What I did
- How I did it
- How to verify it
- Previous command output (if the output of a command-line utility has changed)
- New command output (if the output of a command-line utility has changed)
-->