[config] Add subcommand to configure the status of auto-restart feature for each container #801
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
subcommand to provide a method for user to enable/disable the autorestart feature for specific container. Signed-off-by: Yong Zhao <yozhao@microsoft.com>
jleveque
suggested changes
Feb 5, 2020
There was a problem hiding this comment.
Can you please also add this command and the show command to the Command Reference guide (https://github.com/Azure/sonic-utilities/blob/master/doc/Command-Reference.md) as part of this PR? I forgot to ask for this in the other PR.
|
@jleveque Sure. |
jleveque
suggested changes
Feb 6, 2020
…and feature(). Signed-off-by: Yong Zhao <yozhao@microsoft.com>
Signed-off-by: Yong Zhao <yozhao@microsoft.com>
|
Retest this please |
jleveque
approved these changes
Feb 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Since we introduced the auto-restart feature for each container, we need add a config subcommand to change the current status (enabled/disabled) of auto-restart feature for a specific container.
How I did it
We define a function named autorestart to change the status of a container. This function will accept two parameters which are the container name and new status. If one of parameters is not specified, this function will show the information and then exit.
How to verify it
We can run the command config container feature autorestart container_name autorestart_status.