Add SONiC WPA_SUPPLICANT Plugin #16
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ze Gan <ganze718@gmail.com>
This was referenced Nov 3, 2020
samitabh
reviewed
Nov 26, 2020
src/drivers/driver_macsec_sonic.c
Outdated
| struct driver_wired_common_data common; | ||
|
|
||
| const char * ifname; | ||
| sonic_db_handle sonic_mamager; |
There was a problem hiding this comment.
sonic_mamager -->> sonic_manager (spell check)
src/drivers/driver_macsec_sonic.c
Outdated
| PRINT_LOG("SA %s PN %llu", key, pn); | ||
| if (ret == SONIC_DB_SUCCESS) | ||
| { | ||
| sa->next_pn = pn; |
src/drivers/driver_macsec_sonic.c
Outdated
|
|
||
| char * key = CREATE_SA_KEY(drv->ifname, sa, APP_DB_SEPARATOR); | ||
| PRINT_LOG("%s - %u", key, sa->next_pn); | ||
| char * buffer = create_buffer("%u", sa->next_pn); |
src/drivers/driver_macsec_sonic.c
Outdated
| char * key = CREATE_SA_KEY(drv->ifname, sa, APP_DB_SEPARATOR); | ||
| char * sak_id = create_binary_hex(&sa->pkey->key_identifier, sizeof(sa->pkey->key_identifier)); | ||
| char * sak = create_binary_hex(sa->pkey->key, sa->pkey->key_len); | ||
| char * pn = create_buffer("%u", sa->next_pn); |
There was a problem hiding this comment.
sa->next_pn
should be
sa->lowest_pn
Similar changes below in the function.
src/drivers/driver_macsec_sonic.c
Outdated
| { | ||
| {"sak", sak}, | ||
| {"auth_key", auth_key}, | ||
| {"init_pn", pn}, |
There was a problem hiding this comment.
init_pn --> this is actually next pn. You can change the name for clarity sake.
Pterosaur
force-pushed
the
master
branch
2 times, most recently
from
17af119 to
7b22e02
Compare
Pterosaur
force-pushed
the
wpa/hostap_2_9
branch
from
b3a7502 to
e92ea79
Compare
Pterosaur
force-pushed
the
master
branch
3 times, most recently
from
ec894d6 to
37e9be6
Compare
Signed-off-by: Ze Gan <ganze718@gmail.com>
Pterosaur
force-pushed
the
wpa/hostap_2_9
branch
from
e92ea79 to
9f87f3d
Compare
Signed-off-by: Ze Gan <ganze718@gmail.com>
|
This PR will be closed and moved to #22 . Because the original version is based on branch |
|
@caizhenghui-juniper @samitabh |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SONiC WPA_SUPPLICANT Plugin document can be found at : https://github.com/Azure/SONiC/blob/9edcf67d0e0095e9f831a94ddf4fbb4a267adf7b/doc/macsec/MACsec_hld.md#343-sonic-macsec-plugin
This PR depends on #18
Signed-off-by: Ze Gan ganze718@gmail.com