Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Major GameScope Refactor #744

Merged
merged 31 commits into from
Feb 18, 2023
Merged

Major GameScope Refactor #744

merged 31 commits into from
Feb 18, 2023

Commits on Feb 15, 2023

  1. GameScope: Re-order argument parsing order

    Order now matches the UI more closely
    sonic2kk committed Feb 15, 2023
    Configuration menu
    Copy the full SHA
    eec36ab View commit details
    Browse the repository at this point in the history
  2. GameScope: Move argument parsing into functions

    Now the argument parsing is separated into functions for each
    GameScope 'category' on the UI, it was getting to be a bit of
    a pain to manage all of these arguments.
    sonic2kk committed Feb 15, 2023
    Configuration menu
    Copy the full SHA
    87a6149 View commit details
    Browse the repository at this point in the history
  3. GameScope: Add new ITM options

    Adds ITM (Inverse Tone Mapping) options to the HDR section.
    These were added semi-recently to GameScope.
    Also fixes a bug where one of the already-existing arguments was not properly escaped.
    sonic2kk committed Feb 15, 2023
    Configuration menu
    Copy the full SHA
    6f9c88d View commit details
    Browse the repository at this point in the history
  4. GameScope: Add Expose Wayland options

    Adds '--expose-wayland' option as checkbox.
    Adds the three new GameScope HDR options to UI.
    Minor code refactor.
    sonic2kk committed Feb 15, 2023
    Configuration menu
    Copy the full SHA
    6426518 View commit details
    Browse the repository at this point in the history
  5. Version bump

    sonic2kk committed Feb 15, 2023
    Configuration menu
    Copy the full SHA
    3370ed7 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    3be849e View commit details
    Browse the repository at this point in the history
  7. GameScope: Initial arg fetching refactor

    We now have a general function to do the grepping for GameScope args.
    This is still WIP but has massively reduced the repeated logic for some
    checkboxes.
    
    This will be experimented with and expanded for other checkboxes, but
    this should significantly simplify the GameScope argument logic.
    sonic2kk committed Feb 15, 2023
    Configuration menu
    Copy the full SHA
    3087210 View commit details
    Browse the repository at this point in the history
  8. GameScope: use getGameScopeArg for dropdowns too

    Also has some other refactoring.
    sonic2kk committed Feb 15, 2023
    Configuration menu
    Copy the full SHA
    e04b0ec View commit details
    Browse the repository at this point in the history
  9. GameScope: use getGameScopeArg for Filtering options

    Also fixes a bug where max scale factor was using the wrong flag check.
    sonic2kk committed Feb 15, 2023
    Configuration menu
    Copy the full SHA
    8bd0d3b View commit details
    Browse the repository at this point in the history
  10. GameScope: Use getGameScopeArg for all HDR options

    Also improve getGameScopeArg to use Bash parameter expansion instead of sed.
    sonic2kk committed Feb 15, 2023
    Configuration menu
    Copy the full SHA
    ccc01fe View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    2b5b692 View commit details
    Browse the repository at this point in the history
  12. Configuration menu
    Copy the full SHA
    2b5a93e View commit details
    Browse the repository at this point in the history
  13. remove -template file

    no idea what this was or when it appeared...
    sonic2kk committed Feb 15, 2023
    Configuration menu
    Copy the full SHA
    383b437 View commit details
    Browse the repository at this point in the history
  14. Configuration menu
    Copy the full SHA
    9bc5610 View commit details
    Browse the repository at this point in the history
  15. GameScope: Break some logic into separate function

    Created setGameScopeVars to help trim down GameScopeGui.
    sonic2kk committed Feb 15, 2023
    Configuration menu
    Copy the full SHA
    5948c4a View commit details
    Browse the repository at this point in the history
  16. Configuration menu
    Copy the full SHA
    11f7742 View commit details
    Browse the repository at this point in the history
  17. Configuration menu
    Copy the full SHA
    0982c08 View commit details
    Browse the repository at this point in the history
  18. GameScope: add --rt option

    sonic2kk committed Feb 15, 2023
    Configuration menu
    Copy the full SHA
    a85fdcb View commit details
    Browse the repository at this point in the history
  19. GameScope: minor fix

    sonic2kk committed Feb 15, 2023
    Configuration menu
    Copy the full SHA
    98597e4 View commit details
    Browse the repository at this point in the history
  20. GameScope: use getGameScopeArg for Steam integration option

    This wasn't working before, but seems to be working now? I have no idea.
    sonic2kk committed Feb 15, 2023
    Configuration menu
    Copy the full SHA
    71eda6b View commit details
    Browse the repository at this point in the history
  21. GameScope: add note

    sonic2kk committed Feb 15, 2023
    Configuration menu
    Copy the full SHA
    e54a93d View commit details
    Browse the repository at this point in the history
  22. GameScope: version bump

    sonic2kk committed Feb 15, 2023
    Configuration menu
    Copy the full SHA
    11441ec View commit details
    Browse the repository at this point in the history

Commits on Feb 16, 2023

  1. GameScope: Fix issue with some argument values not being parsed corre…

    …ctly
    
    If there was a single-dash flag after a double-dash flag,
    for example '--cursor /path/to/cursor.png -U --sharpness-value 5',
    then the cursor path would contain the following single-dash flag(s)
    up until the next double dash flag, meaning the path would be read as
    invalid.
    
    This fixes the issue. It was not introduced in this PR but has been
    fixed!
    sonic2kk committed Feb 16, 2023
    Configuration menu
    Copy the full SHA
    fa39f9d View commit details
    Browse the repository at this point in the history
  2. GameScope: change argument building logic

    Previously we used 'mapfile', which we can't use now because
    some arguments may have spaces in their path.
    
    We use new logic now using readarray and some sed magic to
    break up the gamescope arguments and build each argument and its value
    separately.
    sonic2kk committed Feb 16, 2023
    Configuration menu
    Copy the full SHA
    eb897a4 View commit details
    Browse the repository at this point in the history
  3. Revert "GameScope: change argument building logic"

    This reverts commit eb897a4.
    sonic2kk committed Feb 16, 2023
    Configuration menu
    Copy the full SHA
    16edb6a View commit details
    Browse the repository at this point in the history

Commits on Feb 17, 2023

  1. GameScope: Match file paths with spaces

    We use some fancy sed and grep commands to do this.
    ChatGPT actually generated the sed command to surround unquoted paths with quotes.
    sonic2kk committed Feb 17, 2023
    Configuration menu
    Copy the full SHA
    ad65b8f View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    2b4f10b View commit details
    Browse the repository at this point in the history

Commits on Feb 18, 2023

  1. Configuration menu
    Copy the full SHA
    56bf184 View commit details
    Browse the repository at this point in the history
  2. Final tweaks before merge

    sonic2kk committed Feb 18, 2023
    Configuration menu
    Copy the full SHA
    b0f1b7a View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    2ce9836 View commit details
    Browse the repository at this point in the history
  4. Update langfiles

    sonic2kk committed Feb 18, 2023
    Configuration menu
    Copy the full SHA
    c7c32eb View commit details
    Browse the repository at this point in the history