-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Major GameScope Refactor #744
Commits on Feb 15, 2023
-
GameScope: Re-order argument parsing order
Order now matches the UI more closely
Configuration menu - View commit details
-
Copy full SHA for eec36ab - Browse repository at this point
Copy the full SHA eec36abView commit details -
GameScope: Move argument parsing into functions
Now the argument parsing is separated into functions for each GameScope 'category' on the UI, it was getting to be a bit of a pain to manage all of these arguments.
Configuration menu - View commit details
-
Copy full SHA for 87a6149 - Browse repository at this point
Copy the full SHA 87a6149View commit details -
GameScope: Add new ITM options
Adds ITM (Inverse Tone Mapping) options to the HDR section. These were added semi-recently to GameScope. Also fixes a bug where one of the already-existing arguments was not properly escaped.
Configuration menu - View commit details
-
Copy full SHA for 6f9c88d - Browse repository at this point
Copy the full SHA 6f9c88dView commit details -
GameScope: Add Expose Wayland options
Adds '--expose-wayland' option as checkbox. Adds the three new GameScope HDR options to UI. Minor code refactor.
Configuration menu - View commit details
-
Copy full SHA for 6426518 - Browse repository at this point
Copy the full SHA 6426518View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3370ed7 - Browse repository at this point
Copy the full SHA 3370ed7View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3be849e - Browse repository at this point
Copy the full SHA 3be849eView commit details -
GameScope: Initial arg fetching refactor
We now have a general function to do the grepping for GameScope args. This is still WIP but has massively reduced the repeated logic for some checkboxes. This will be experimented with and expanded for other checkboxes, but this should significantly simplify the GameScope argument logic.
Configuration menu - View commit details
-
Copy full SHA for 3087210 - Browse repository at this point
Copy the full SHA 3087210View commit details -
GameScope: use getGameScopeArg for dropdowns too
Also has some other refactoring.
Configuration menu - View commit details
-
Copy full SHA for e04b0ec - Browse repository at this point
Copy the full SHA e04b0ecView commit details -
GameScope: use getGameScopeArg for Filtering options
Also fixes a bug where max scale factor was using the wrong flag check.
Configuration menu - View commit details
-
Copy full SHA for 8bd0d3b - Browse repository at this point
Copy the full SHA 8bd0d3bView commit details -
GameScope: Use getGameScopeArg for all HDR options
Also improve getGameScopeArg to use Bash parameter expansion instead of sed.
Configuration menu - View commit details
-
Copy full SHA for ccc01fe - Browse repository at this point
Copy the full SHA ccc01feView commit details -
Configuration menu - View commit details
-
Copy full SHA for 2b5b692 - Browse repository at this point
Copy the full SHA 2b5b692View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2b5a93e - Browse repository at this point
Copy the full SHA 2b5a93eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 383b437 - Browse repository at this point
Copy the full SHA 383b437View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9bc5610 - Browse repository at this point
Copy the full SHA 9bc5610View commit details -
GameScope: Break some logic into separate function
Created setGameScopeVars to help trim down GameScopeGui.
Configuration menu - View commit details
-
Copy full SHA for 5948c4a - Browse repository at this point
Copy the full SHA 5948c4aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 11f7742 - Browse repository at this point
Copy the full SHA 11f7742View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0982c08 - Browse repository at this point
Copy the full SHA 0982c08View commit details -
Configuration menu - View commit details
-
Copy full SHA for a85fdcb - Browse repository at this point
Copy the full SHA a85fdcbView commit details -
Configuration menu - View commit details
-
Copy full SHA for 98597e4 - Browse repository at this point
Copy the full SHA 98597e4View commit details -
GameScope: use getGameScopeArg for Steam integration option
This wasn't working before, but seems to be working now? I have no idea.
Configuration menu - View commit details
-
Copy full SHA for 71eda6b - Browse repository at this point
Copy the full SHA 71eda6bView commit details -
Configuration menu - View commit details
-
Copy full SHA for e54a93d - Browse repository at this point
Copy the full SHA e54a93dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 11441ec - Browse repository at this point
Copy the full SHA 11441ecView commit details
Commits on Feb 16, 2023
-
GameScope: Fix issue with some argument values not being parsed corre…
…ctly If there was a single-dash flag after a double-dash flag, for example '--cursor /path/to/cursor.png -U --sharpness-value 5', then the cursor path would contain the following single-dash flag(s) up until the next double dash flag, meaning the path would be read as invalid. This fixes the issue. It was not introduced in this PR but has been fixed!
Configuration menu - View commit details
-
Copy full SHA for fa39f9d - Browse repository at this point
Copy the full SHA fa39f9dView commit details -
GameScope: change argument building logic
Previously we used 'mapfile', which we can't use now because some arguments may have spaces in their path. We use new logic now using readarray and some sed magic to break up the gamescope arguments and build each argument and its value separately.
Configuration menu - View commit details
-
Copy full SHA for eb897a4 - Browse repository at this point
Copy the full SHA eb897a4View commit details -
Revert "GameScope: change argument building logic"
This reverts commit eb897a4.
Configuration menu - View commit details
-
Copy full SHA for 16edb6a - Browse repository at this point
Copy the full SHA 16edb6aView commit details
Commits on Feb 17, 2023
-
GameScope: Match file paths with spaces
We use some fancy sed and grep commands to do this. ChatGPT actually generated the sed command to surround unquoted paths with quotes.
Configuration menu - View commit details
-
Copy full SHA for ad65b8f - Browse repository at this point
Copy the full SHA ad65b8fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 2b4f10b - Browse repository at this point
Copy the full SHA 2b4f10bView commit details
Commits on Feb 18, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 56bf184 - Browse repository at this point
Copy the full SHA 56bf184View commit details -
Configuration menu - View commit details
-
Copy full SHA for b0f1b7a - Browse repository at this point
Copy the full SHA b0f1b7aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 2ce9836 - Browse repository at this point
Copy the full SHA 2ce9836View commit details -
Configuration menu - View commit details
-
Copy full SHA for c7c32eb - Browse repository at this point
Copy the full SHA c7c32ebView commit details