Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compatdata Redirect: Add option to only redirect on major Proton versions #867

Merged
merged 3 commits into from
Jul 23, 2023

Conversation

sonic2kk
Copy link
Owner

@sonic2kk sonic2kk commented Jul 22, 2023

Implements #866.

Adds a checkbox on the Game Menu that will only create a new compatdata redirect folder on major Proton version bumps.

The default behaviour right now is to make a new compatdata redirect on each new Proton version, including minor fix versions. So a user could end up with compatdata-proton-8.0-2d, compatdata-proton-8.0-3c, compatdata-GE-Proton8-6 and so on. This new option will only create new compatdata directories for major version bumps, such as compatdata-proton-8.0 or compatdata-GE-Proton8.

SteamTinkerLaunch should be able to automatically pick up and switch to using compatdata-proton-XX over the folder with the minor fix version. In testing going between both of these options worked without issue, the logs also indicated that the compatdata for the game I was testing with was being selected correctly.

TODO:

  • Testing from OP who reported the issue
  • Update langfiles

@sonic2kk
Copy link
Owner Author

Initial testing from OP is looking good, this is probably ready to merge once langfiles are updated, unless anything last-minute comes up.

@sonic2kk
Copy link
Owner Author

Updated the description string slightly. ShellCheck is good for this and the version is bumped, so this is good to merge.

@sonic2kk sonic2kk merged commit 71d9848 into master Jul 23, 2023
@sonic2kk sonic2kk deleted the compatredir-major-proton branch July 23, 2023 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant