Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: more nvidia related .so files for volumes #1907

Merged
merged 2 commits into from
Apr 15, 2020
Merged

Conversation

nikonov1101
Copy link
Member

Found out that we're skipping a lot of useful nvidia's .so files.
This PR adds all of them to the docker volume.
Based on the content of NVIDIA-Linux-x86_64-440.82.

To keep the list up-to-date in the future:

  1. download the latest version on drivers;
  2. unpack them without installing: ./NVIDIA-Linux-x86_64-XXX.YY.run --extract-only;
  3. list .so and update the list in insonmnia/worker/gpu/nvidia_tuner.go; Don't forget to remove versions and .0 from file names;
  4. ???
  5. Congratulation, you're awesome open-source contributor;

Found out that we're skipping a lot of useful nvidia's .so files.
This PR adds all of them to the docker volume.
Based on the content of NVIDIA-Linux-x86_64-440.82.

To keep the list up-to-date in the future:
1. download the latest version on drivers;
2. unpack them without installing: `./NVIDIA-Linux-x86_64-XXX.YY.run --extract-only`;
3. list .so and update the list in `insonmnia/worker/gpu/nvidia_tuner.go`; Don't forget to remove versions and .0 from file names;
4. ???
5. Congratulation, you're awesome open-source contributor;
Copy link
Collaborator

@antmat antmat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@3Hren
Copy link
Member

3Hren commented Apr 13, 2020

I express my LGBT

@nikonov1101 nikonov1101 merged commit a216792 into master Apr 15, 2020
@nikonov1101 nikonov1101 deleted the fix/gpu/more-so branch April 15, 2020 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants