Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: dwh tests #1908

Merged
merged 2 commits into from
Apr 15, 2020
Merged

fix: dwh tests #1908

merged 2 commits into from
Apr 15, 2020

Conversation

sokel
Copy link
Member

@sokel sokel commented Apr 14, 2020

This PR fixes behavior with dwh test suite:

  • add required for run POSTGRES_PASSWORD environment
  • returns an error when Postgres not started any times, not null
  • format touched file imports

@sokel sokel added 💩 T: bug This PR/Issue fixes a bug S: DWH This PR/Issue changes DWH P: HIGH This PR/Issue has the high priority labels Apr 14, 2020
@sokel sokel requested a review from zavgorodnii as a code owner April 14, 2020 19:03
* add required for run `POSTGRES_PASSWORD` environment
* returns an error when Postgres not started any times, not null
* format touched file imports
nikonov1101
nikonov1101 previously approved these changes Apr 14, 2020
Copy link
Member

@nikonov1101 nikonov1101 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

L2GBT

Co-Authored-By: ALex Nikonov <alex@sshaman.ru>
Copy link
Member

@nikonov1101 nikonov1101 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

L3GBT

Copy link
Member

@3Hren 3Hren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like shit. Approved!

Copy link
Collaborator

@antmat antmat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Лукс гуд ту ми

Copy link
Contributor

@zavgorodnii zavgorodnii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

дурка ебать

@3Hren 3Hren merged commit 25b1581 into master Apr 15, 2020
@3Hren 3Hren deleted the fix/dwh-tests branch April 15, 2020 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P: HIGH This PR/Issue has the high priority S: DWH This PR/Issue changes DWH 💩 T: bug This PR/Issue fixes a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants