Skip to content

Commit

Permalink
Revert url lib bump to 2.1.0
Browse files Browse the repository at this point in the history
A regression in the `url` patch 2.1.1 caused cargo to panic when
compiling crates with git ssh dependencies. This is described in
servo/rust-url#577. A workaround has been deployed in cargo 0.43, but
the version is not yet released. On the meantime, dinghy should use the
url version 2.1.0.
  • Loading branch information
Deluvi committed Feb 13, 2020
1 parent aec22b3 commit 2048f31
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 6 deletions.
13 changes: 7 additions & 6 deletions Cargo.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions dinghy-lib/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,7 @@ toml = "0.5"
shell-escape = "0.1"
walkdir = "2.0"
which = "3.0"
url = "= 2.1.0" # The `url` version 2.1.1 introduced a regression in Cargo (https://github.com/servo/rust-url/issues/577). This line should be removed once `cargo` lib is updated to support ssh urls again. It should be included in `cargo` 0.43: https://github.com/rust-lang/cargo/pull/7787/commits/dde27346685e09166967616581aac383918b2c04#diff-1dc41e0ad8fa6e5cafa93ac2d22c67f3

[target.'cfg(target_os="macos")'.dependencies]
core-foundation = "0.5"
Expand Down

0 comments on commit 2048f31

Please sign in to comment.