Use devicectl for launching on iOS 17 or greater. #214
Conversation
| let signing = xcode::look_for_signature_settings(&self.id)? | ||
| .pop() | ||
| .ok_or_else(|| anyhow!("no signing identity found"))?; | ||
| let app_id = signing | ||
| .name | ||
| .split(" ") | ||
| .last() | ||
| .ok_or_else(|| anyhow!("no app id ?"))?; |
There was a problem hiding this comment.
From what I can tell, devicectl requires using the app bundle id. It fails when just Dinghy is used.
Ideally, this would just use the already called xcode::look_for_signature_settings that was used in make_app. I every way I looked, this required modifying BuildBundle or the Device trait both seemed worse than this option.
| @@ -24,6 +24,10 @@ pub fn add_plist_to_app( | |||
| plist, | |||
| "<key>CFBundleExecutable</key><string>Dinghy</string>", | |||
| )?; | |||
| writeln!( | |||
| plist, | |||
| "<key>CFBundleName</key><string>Dinghy</string>", | |||
There was a problem hiding this comment.
I'm not sure why but devicectl wouldn't work without this key.
|
Nice ! I'm gonna work on an alternative solution based on pymobiledevice because many things we do rely on more than just launching (fetching stdout and return value for instance). But it may be nice to have an alternative workflow like this for simple cases. |
Thanks! This solution doesn't get any stdout. To verify things actually work, I either use a bevy example to draw stuff or use the macOS console app to view the logs that go into the apple unified logging system using I spent a bit of time yesterday trying to how |
|
Superseeded by #215. |
Related to #204.
As of b22d5ed, I've tested this on: