Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added marshalling to main thread messages sent from native side #422

Merged
merged 3 commits into from
Sep 6, 2024
Merged

Added marshalling to main thread messages sent from native side #422

merged 3 commits into from
Sep 6, 2024

Conversation

Kofhein
Copy link
Contributor

@Kofhein Kofhein commented Sep 6, 2024

This commit adds marshalling of messages sent from native side to be executed on main thread

@Kofhein Kofhein mentioned this pull request Sep 6, 2024
Closed
@HidenoriMatsubayashi
Copy link
Contributor

Thank you for this PR, @Kofhein.

Could you please update AUTHORS too? Also, it's unclear whether we can contribute this software to flutter/engine, but do you agree to delegate all rights related to this PR to Sony?

@HidenoriMatsubayashi HidenoriMatsubayashi linked an issue Sep 6, 2024 that may be closed by this pull request
Native messages marshalling and main loop #421
Closed
@HidenoriMatsubayashi HidenoriMatsubayashi added bug Something isn't working plugin Topics of flutter plugins for embedded linux labels Sep 6, 2024
@Kofhein
Copy link
Contributor Author

Kofhein commented Sep 6, 2024

@HidenoriMatsubayashi , AUTHORS updated, yes, I agree

@HidenoriMatsubayashi
Copy link
Contributor

Thank you, Kofhein.

HidenoriMatsubayashi
HidenoriMatsubayashi approved these changes Sep 6, 2024
View reviewed changes
Copy link
Contributor

@HidenoriMatsubayashi HidenoriMatsubayashi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you.

@HidenoriMatsubayashi HidenoriMatsubayashi merged commit 30b3d4a into sony:master Sep 6, 2024
1 check passed
@barribarrier barribarrier mentioned this pull request Sep 26, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HidenoriMatsubayashi HidenoriMatsubayashi HidenoriMatsubayashi approved these changes

Assignees
No one assigned
Labels
bug Something isn't working plugin Topics of flutter plugins for embedded linux
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Native messages marshalling and main loop
2 participants
@Kofhein @HidenoriMatsubayashi