Upstream json-schema-validator target name is non-namespaced #297
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Both non-namespaced and namespaced target names work with the Conan cmake_find_package generator, but after the recipe switches to CMakeDeps the namespaced one may be gone, so better to align with the upstream
garethsb
added a commit
to garethsb/conan-center-index
that referenced
this pull request
Nov 15, 2022
garethsb
added a commit
to garethsb/conan-center-index
that referenced
this pull request
Nov 15, 2022
garethsb
added a commit
to garethsb/conan-center-index
that referenced
this pull request
Nov 15, 2022
garethsb
added a commit
to garethsb/conan-center-index
that referenced
this pull request
Nov 17, 2022
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Both non-namespaced and namespaced target names work with the Conan cmake_find_package generator, but after we switch over to the CMakeDeps generator the namespaced one may be gone, so better to align with the upstream.
See https://github.com/pboettch/json-schema-validator/blob/2.1.0/CMakeLists.txt