Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix readthedocs and cython dependency #1211

Merged
merged 2 commits into from
Aug 1, 2023

Conversation

TomonobuTsujikawa
Copy link
Contributor

During the release process of nnabla v1.36.0, we found the python package conflict for Readthedocs build environment, referred as #1207. This PR do fix the conflict and the documents are generated correctly. But after the release finished, the document is found that fail in switching between different version by the click button. User could only switch by manually modifying the URL.

The reason for this issue is also caused by python build environment. As the Sphinx is upgraded(though limited to be lower than 7), the sphinx-rtd-theme is still kept to be 0.4.3. This won't cause build error, however, would still cause such incompatibility. So in this PR, sphinx-rtd-theme is also upgraded.

For version <= 1.0.0, sphinx-rtd-theme shows no dependency requirement. For version <=1.1.1, >1.0, it requires sphinx >=1.6, <6. For version >=1.2.0, it requires sphinx >=1.6, <7. So we choose to limit sphinx-rtd-theme>=1.2.

In addition, the current CIs are blocked by the cython v3.0.0 which was released at 17th July.
This cause several Cython compile error during nnabla build, so we temporally limit the Cython version.

@YukioOobuchi YukioOobuchi merged commit ce3f339 into master Aug 1, 2023
@YukioOobuchi YukioOobuchi deleted the feature/20230718-rtd-dependency branch August 1, 2023 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants