-
Notifications
You must be signed in to change notification settings - Fork 334
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement OrthogonalInitializer #265
Conversation
PS. Are there C++ initialization codes? I could not find any files related to weight initialization. |
Thanks for the PR.
No C++ initialization so far. All weight initialization is performed in Python-side. |
@takuseno I'll review soon. |
It must be useful for many people, and the code logic looks good to me. Thanks for your PR. Could you add unit tests for this feature? See the unit testing script for initializers which we just added at #270 for this PR :). |
@TE-TakuyaNarihira Thank you! I'll handle that! |
@TE-TakuyaNarihira |
474a898
to
07fea2a
Compare
@TE-KazukiYoshiyama san. I set a default rng with |
This PR is moved to #547 and will be merged to master. |
add CDC to StyleGAN2
Hi, @TE-TakuyaNarihira san, @TE-AkioHayakawa san!
#243 takes a bit time because my school started 😢
Anyway, I implemented
OrthogonalInitializer
which is widely available on other DNN libraries but still effective way in many domains.If you think it might be good to nnabla, I will test this more to remove WIP sign.
Thank you!