Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement batch_det function #366

Closed
wants to merge 33 commits into from
Closed

Conversation

takuseno
Copy link
Contributor

@takuseno takuseno commented Feb 25, 2019

Hi, @TE-AkioHayakawa san, @TE-TakuyaNarihira san.

I've implemented batch_det function that computes determinant of input array.

a = nn.Variable((2, 13, 13))
det = F.batch_det(a) # det.shape == (2,)

nd = np.random.random((2, 13, 13))
a.d = nd
det.forward()

assert np.allclose(det.d, np.array(list(map(np.linalg.det, nd))))

batch_det works with forward and backward correctly now. cuda extension is implemented.

@takuseno
Copy link
Contributor Author

takuseno commented Mar 1, 2019

cuda version is implemented sony/nnabla-ext-cuda#132

@takuseno
Copy link
Contributor Author

@TE-KazukiYoshiyama san reviewed this

@TakuyaNarihira TakuyaNarihira added release-note-ignore Auto-release; Not Appeared in Release Notes release-note-op-layer Auto-release; Layer Functions and removed release-note-ignore Auto-release; Not Appeared in Release Notes labels Apr 3, 2019
@takuseno
Copy link
Contributor Author

takuseno commented Dec 3, 2019

@TE-AkioHayakawa
I've resolved conflict. Now, it's ready for merge :)

@AkioHayakawa-sony
Copy link
Member

@takuseno
Thanks a lot!
Could you do the same thing for sony/nnabla-ext-cuda#132 ?

@takuseno
Copy link
Contributor Author

takuseno commented Dec 3, 2019

@TE-AkioHayakawa
I've resolved that conflict. The cuda implementation is ready for merge too :)

@AkioHayakawa-sony
Copy link
Member

AkioHayakawa-sony commented Dec 4, 2019

@takuseno
One more minor thing. Could you update doc/python/api/function.rst?
FYI, see https://github.com/sony/nnabla/pull/550/files as a reference.

@takuseno takuseno mentioned this pull request Dec 4, 2019
@takuseno
Copy link
Contributor Author

takuseno commented Dec 4, 2019

@TE-AkioHayakawa
I've added batch_det to document. And, squashed version of PR is created as #553 . If you prefer the new PR, I'd like you to see it :)

@AkioHayakawa-sony
Copy link
Member

@takuseno
Thanks a lot! It looks Nice!
I will see #533 and run CI testing again. Please wait a moment.

TE-StephenTiedemann pushed a commit that referenced this pull request Feb 18, 2022
…-device-copy

Add AssignCuda not to perform host-device copy
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note-op-layer Auto-release; Layer Functions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants