Use dtype of RHS in NdArray.data setter #527
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, there was an issue that an array with any dtype is automatically converted to fp32 at the first call of
.data
property in an instance ofNdArray
.By this change, the setter uses a dtype of RHS as following.
There is an exception where
zero()
orfill(rhs)
is invoked if a scalar with a float or an integer <= 2^53 (as value to be filled is maintained as float64) is given.Additionally, resolved the following;