Wakelock parsing #75
Merged
Wakelock parsing #75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Wait on merging this... I think I've found more wakelocks to parse :) |
|
Now parsing more wake locks, there are still some double wakelocks that we're not parsing shown in the logs like so: I think we can probably look at merging this, and opening a bug for it. We should also review CPU usage, and CPU usage per proc to see if it's correct, they've "re-appeared" after fixing a related parsing bug. |
|
Reviewed CPU/ CPU per proc, they look correct (at a glance). Also added parsing of FG time which is in the same lines... |
Some graphs have quite long scales, in these cases it is better with a day time stamp instead of hours.
Get a much longer log then we get from the event log battery events.
edsj-sony
reviewed
Feb 5, 2020
|
@edsj-sony any more comments on this one? |
edsj-sony
requested changes
Feb 11, 2020
core/src/com/sonyericsson/chkbugreport/plugins/battery/WakeLock.java
Outdated
Show resolved
Hide resolved
edsj-sony
reviewed
Feb 13, 2020
core/src/com/sonyericsson/chkbugreport/plugins/battery/WakeLock.java
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve wakelock parsing. Also bump revision since we have recovered more functionality.