Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remind: .in does not reply() with errors #1644

Closed
dgw opened this issue Jun 24, 2019 · 0 comments · Fixed by #1715
Closed

remind: .in does not reply() with errors #1644

dgw opened this issue Jun 24, 2019 · 0 comments · Fixed by #1715
Assignees
@Exirel
Labels
Easyfix Bugs or Tweaks that are easy for a new contributor to fix or implement Low Priority
Milestone
7.0.0

Comments

@dgw
Copy link
Member

dgw commented Jun 24, 2019 •
edited
Loading

Generally (there are likely other exceptions; I haven't exhaustively searched all plugins while on vacation) Sopel uses bot.reply() for errors, to get the attention of the user who issued the failed command so they can (hopefully) fix the problem and try again.

The .in command doesn't, though. It uses bot.say(). We should fix that.
@dgw dgw added Low Priority Easyfix Bugs or Tweaks that are easy for a new contributor to fix or implement Patches Welcome labels Jun 24, 2019
@dgw dgw added this to the 7.0.0 milestone Jun 24, 2019
Exirel added a commit to Exirel/sopel that referenced this issue Oct 22, 2019
@Exirel
remind: use reply in case of error fix sopel-irc#1644
e05d719
@Exirel Exirel mentioned this issue Oct 22, 2019
Merged
@Exirel Exirel self-assigned this Oct 22, 2019
@dgw dgw closed this as completed in #1715 Nov 11, 2019
dgw added a commit that referenced this issue Nov 11, 2019
@dgw
Merge pull request #1715 from Exirel/remind-error-reply
b33173c 
remind: use reply in case of error fix #1644
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Exirel Exirel

Labels
Easyfix Bugs or Tweaks that are easy for a new contributor to fix or implement Low Priority
Projects
None yet
Milestone
7.0.0
Development

Successfully merging a pull request may close this issue.

remind: use reply in case of error fix #1644 Exirel/sopel
2 participants
@dgw @Exirel