Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

url: exclude setting also applies to .title command #2054

Closed
dgw opened this issue Apr 25, 2021 · 0 comments · Fixed by #2282
Closed

url: exclude setting also applies to .title command #2054

dgw opened this issue Apr 25, 2021 · 0 comments · Fixed by #2282
Labels
Bug Things to squish; generally used for issues Medium Priority
Milestone

Comments

@dgw
Copy link
Member

dgw commented Apr 25, 2021

Description

Before Sopel 7.1, the only sane way to disable auto-title would have been setting the config option url.exclude to .* (matching any possible URL). The only problem is, doing that also makes .title not work.

At least as far back as Willie 4.0.0, when the responsible code was restructured (in d1acb12), and probably even longer, doing e.g. .title http://thisurlis.excluded would yield silence from the bot.

Recently, the silence has changed to an error message, since it's impossible for the code added in #1380 (then re-added in #2029) to tell the difference between a failed fetch, an excluded link, or a link handled by some other plugin.

Reproduction steps

  1. Set url.exclude to .*
  2. Run .title http://any.link/of/your/choosing
  3. Get an error: "Sorry, fetching that title failed. Make sure the site is working."

Expected behavior

I expect Sopel to try and fetch the link's title anyway, because it's been explicitly requested.

Environment

  • Sopel .version: 7.1.0-dev
  • Sopel installed via: pip install -e
  • Python version: 3.8.5
  • Operating system: Ubuntu 18.04
  • Relevant plugins: url

Notes

Since this behavior has been around for so long, I elected to hold any change until 8.0, even though any fix is probably trivial enough to include in 7.1 still. We'd be changing the meaning of a setting.

It seems easiest to fix both this and #2055 at the same time.

@dgw dgw added the Bug Things to squish; generally used for issues label Apr 25, 2021
@dgw dgw added this to the 8.0.0 milestone Apr 25, 2021
@dgw dgw closed this as completed in #2282 Jun 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Things to squish; generally used for issues Medium Priority
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants